This stops passing "now" as the SOURCE_DATE_EPOCH to apko.
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have made changes to `apko` to compute the "build date epoch" based on `MAX(installed packages builddate)`, which should make the image timestamp a reflection of the last time one of the packages contributing to the image changed. This should result in significantly less nightly churn from image rebuilds where only the timestamp changes. Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
use-build-date-epoch
branch
from
03821f5
to
bd0c030
Compare
|
Needs: wolfi-dev/os#2264 to land first, lest we revert to the unix epoch for some images. |
|
I confirmed that an |
kaniini
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have made changes to
apkoto compute the "build date epoch" based onMAX(installed packages builddate), which should make the image timestamp a reflection of the last time one of the packages contributing to the image changed.This should result in significantly less nightly churn from image rebuilds where only the timestamp changes.