Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chainer: Simplify n_step_lstm test #7807

Merged
merged 8 commits into from
Aug 12, 2019
Merged

Chainer: Simplify n_step_lstm test #7807

merged 8 commits into from
Aug 12, 2019

Conversation

dido1998
Copy link
Contributor

No description provided.

@niboshi niboshi added the GSoC label Jul 25, 2019
@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit e0136fd, target branch master) failed with status FAILURE.

@take-cheeze
Copy link
Member

The jenkins failure seems to be unrelated

@take-cheeze
Copy link
Member

ChainerCI, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 576e1d6, target branch master) failed with status FAILURE.

@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 576e1d6, target branch master) failed with status FAILURE.

@dido1998
Copy link
Contributor Author

Is this failure related to this PR?

@take-cheeze
Copy link
Member

Seems jenkins error doesn't relate to this PR so don't mind since pfn ci is working fine

@take-cheeze
Copy link
Member

Jenkins, test this please!

take-cheeze
take-cheeze approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@take-cheeze take-cheeze added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Jul 31, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 576e1d6, target branch master) failed with status FAILURE.

@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 576e1d6, target branch master) failed with status FAILURE.

@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 576e1d6, target branch master) failed with status FAILURE.

@chainer-ci
Copy link
Member

@take-cheeze This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@take-cheeze take-cheeze removed the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Aug 4, 2019
@take-cheeze
Copy link
Member

ChainerCI, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 576e1d6, target branch master) succeeded!

@dido1998
Copy link
Contributor Author

@take-cheeze can this be merged?

@dido1998 dido1998 mentioned this pull request Aug 12, 2019
Merged
@take-cheeze
Copy link
Member

Seems to be OK. Thanks for reminding me.

@take-cheeze
Copy link
Member

ChainerCI, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 576e1d6, target branch master) failed with status FAILURE.

@take-cheeze take-cheeze merged commit 3bf5bfe into chainer:master Aug 12, 2019
@kmaehashi kmaehashi added this to the v7.0.0b3 milestone Aug 22, 2019
@kmaehashi kmaehashi added the cat:test Test or CI related. label Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@take-cheeze take-cheeze take-cheeze approved these changes

Assignees

@take-cheeze take-cheeze

Labels
cat:test Test or CI related. GSoC
Projects
None yet
Milestone
v7.0.0b3
Development

Successfully merging this pull request may close these issues.
5 participants
@dido1998 @take-cheeze @chainer-ci @niboshi @kmaehashi