Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSTM, GRU and RNN implementation for ChainerX #7764

Merged
merged 67 commits into from
Aug 19, 2019
Merged

LSTM, GRU and RNN implementation for ChainerX #7764

merged 67 commits into from
Aug 19, 2019

Conversation

dido1998
Copy link
Contributor

@dido1998 dido1998 commented Jul 15, 2019 •
edited
Loading

This depends on #7807

dido1998 added 30 commits May 16, 2019 22:04
@dido1998
implementing simple lstm function
c1ed7a5
@dido1998
implementation lstm activation function
f88460e
@dido1998
implementation of n_step_lstm
f6954d2
@dido1998
fix formatting
2f142de
@dido1998
fix formatting
0db2e42
@dido1998
merge with master
3124124
@dido1998
fix compile errors
a11cb63
@dido1998
fix python formatting
7adc07e
@dido1998
fix errors in test_connection.py
3830e68
@dido1998
fix formatting
c449375
@dido1998
fix syntax errors
e6755ca
@dido1998
fix return error
0a77595
@dido1998
fix c formatting
b66996b
@dido1998
implemetation of n_step_bi_lstm
5692af0
@dido1998
fix c formatting
d01d703
@dido1998
added cuddn rnn forward implementation
b0ee988
@dido1998
cudnn rnn implementation
14b2d0b
@dido1998
remove unnecessary debug messages
405bc36
@dido1998
adding remaining files
6736a02
@dido1998
Merge branch 'LSTM' of https://github.com/dido1998/chainer into LSTM
3a0ec64
@dido1998
cudnn code fixed
e9cdba8
@dido1998
adding incomplete test code for cuda LSTM
e5ab97b
@dido1998
completed cudnn error-free code
74085fa
@dido1998
changing usage of AsContiguous
6d48e97
@dido1998
adding deleted file
da42d96
@dido1998
using the same descriptor for forward and backward pass
87c7678
@dido1998
merge with chainerx master
fdcaa1a
@dido1998
fixing compile errors
9914ee8
@dido1998
working backward pass for cudnn n_step_lstm
f38147a
@dido1998
fixing cpplint errors
ca6a79d
@dido1998 dido1998 changed the title Vanilla rnn implementation for ChainerX LSTM, GRU and RNN implementation for ChainerX Aug 13, 2019
@niboshi niboshi self-assigned this Aug 14, 2019
@asi1024 asi1024 removed the st:blocked-by-another-pr State indicating that another ticket is preventing this ticket from being closed/merged. label Aug 14, 2019
niboshi
niboshi requested changes Aug 14, 2019
View reviewed changes
chainerx_cc/chainerx/routines/connection.cc Outdated Show resolved Hide resolved
chainerx_cc/chainerx/routines/connection.cc Outdated Show resolved Hide resolved
chainerx_cc/chainerx/backward_builder.cc Outdated Show resolved Hide resolved
niboshi
niboshi requested changes Aug 15, 2019
View reviewed changes
chainerx_cc/chainerx/cuda/cuda_device/rnn.cu Outdated Show resolved Hide resolved
chainerx_cc/chainerx/cuda/cuda_device/rnn.cu Outdated Show resolved Hide resolved
chainerx_cc/chainerx/routines/n_step_rnn.cc Outdated Show resolved Hide resolved
chainerx_cc/chainerx/routines/n_step_rnn.cc Show resolved Hide resolved
@dido1998
Copy link
Contributor Author

@niboshi could you review this, I have made the changes

@niboshi
Copy link
Member

niboshi commented Aug 16, 2019

Thanks!
Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit becf72c, target branch master) failed with status FAILURE.

niboshi
niboshi requested changes Aug 19, 2019
View reviewed changes
chainerx_cc/chainerx/routines/connection.cc Outdated Show resolved Hide resolved
chainerx_cc/chainerx/routines/n_step_rnn.cc Outdated Show resolved Hide resolved
@niboshi
Copy link
Member

niboshi commented Aug 19, 2019

Thanks!
Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 2767db3, target branch master) failed with status FAILURE.

@niboshi
Copy link
Member

niboshi commented Aug 19, 2019

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit a8d9806, target branch master) succeeded!

@niboshi
Copy link
Member

niboshi commented Aug 19, 2019

Test failure is unrelated.
Thank you so much!

@niboshi niboshi merged commit 07e6c53 into chainer:master Aug 19, 2019
@niboshi niboshi added this to the v7.0.0b3 milestone Aug 19, 2019
@niboshi niboshi added the ChainerX Related to ChainerX. label Aug 19, 2019
@toslunar toslunar mentioned this pull request Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niboshi niboshi niboshi requested changes

Assignees

@niboshi niboshi

@asi1024 asi1024

Labels
cat:feature Implementation that introduces new interfaces. ChainerX Related to ChainerX. GSoC
Projects
None yet
Milestone
v7.0.0b3
Development

Successfully merging this pull request may close these issues.
4 participants
@dido1998 @asi1024 @niboshi @chainer-ci