Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not build on nightly rust // Can't build any embassy example at all! #29

Open
jsprog opened this issue Jun 18, 2024 · 5 comments
Open

Can not build on nightly rust // Can't build any embassy example at all! #29

jsprog opened this issue Jun 18, 2024 · 5 comments

Comments

@jsprog
Copy link

jsprog commented Jun 18, 2024

I'm having a hard time trying to make at least one embassy example work. Unfortunately, I confirmed that none of the official examples worked, event with the newer cargo-generate template (ch32-hal-template). According to other issues and discussions in this repository, it appears that this problem is unlikely to be affecting every developer! probably proc-macro incompatibilities across nightly revisions!

The error messages bellow were received after trying to build examples/ch32v003/src/bin/embassy_blinky.rs with cargo build --release --bin embassy_blinky.rs or cargo build --bin embassy_blinky.rs and I confirmed that I'm receiving the same error messages with every other embassy example regardless of the target device.

  • nightly-x86_64-unknown-linux-gnu - rustc 1.81.0-nightly (59e2c01c2 2024-06-17)
  • extracted the download from https://github.com/ch32-rs/ch32-hal (current-rev: 56de16c) as it is, and inspected the the examples from their current directories. the non embassy examples I tested worked perfectly.

Build errors

error: item does not constrain `blink::Fut::{opaque#0}`, but has it in its signature
  --> src/bin/embassy_blinky.rs:11:1
   |
11 | #[embassy_executor::task(pool_size = 2)]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: consider moving the opaque type's declaration and defining uses into a separate module
note: this opaque type is in the signature
  --> src/bin/embassy_blinky.rs:11:1
   |
11 | #[embassy_executor::task(pool_size = 2)]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = note: this error originates in the attribute macro `embassy_executor::task` (in Nightly builds, run with -Z macro-backtrace for more info)
error: item does not constrain `__embassy_main::Fut::{opaque#0}`, but has it in its signature
  --> src/bin/embassy_blinky.rs:23:1
   |
23 | #[embassy_executor::main(entry = "qingke_rt::entry")]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: consider moving the opaque type's declaration and defining uses into a separate module
note: this opaque type is in the signature
  --> src/bin/embassy_blinky.rs:23:1
   |
23 | #[embassy_executor::main(entry = "qingke_rt::entry")]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = note: this error originates in the attribute macro `::embassy_executor::task` (in Nightly builds, run with -Z macro-backtrace for more info)

More Details from Rust Analyzer

proc-macro panicked: failed to load macro: Failed to get file metadata for /home/developer/dev/ch32-hal/examples/ch32v003/target/debug/deps/libembassy_executor_macros-ca73f4ef56da3f51.so: No such file or directory (os error 2)rust-analyzer[macro-error](https://rust-analyzer.github.io/manual.html#macro-error)
@jsprog
Copy link
Author

jsprog commented Jun 18, 2024

Already reported by others here embassy-rs/embassy#3078 and likely the issues is affecting embassy since nightly-2024-06-13

@andelf
Copy link
Contributor

andelf commented Jun 19, 2024

Thanks. A nightly rust-toolchain lock should be added before embassy's next crates.io release.

@romainreignier romainreignier mentioned this issue Jun 19, 2024
Closed
romainreignier added a commit to ch32-rs/ch32-hal-template that referenced this issue Jun 19, 2024
@romainreignier
Pin the rust nightly version to avoid the TAIT issue. Fix #2
56f9b05 
And add the requested target.

See ch32-rs/ch32-hal#29 and embassy-rs/embassy#3078
andelf added a commit that referenced this issue Jun 20, 2024
@andelf
fix(build): lock nightly toolchain
91eb59d 
See-also: #29
@andelf andelf changed the title Can't build any embassy example at all! Can not build on nightly rust // Can't build any embassy example at all! Jun 20, 2024
@andelf andelf mentioned this issue Jun 20, 2024
Merged
andelf added a commit that referenced this issue Jun 20, 2024
@andelf
fix(build): lock nightly toolchain (#31)
2ee0af2 
* fix(build): lock nightly toolchain

See-also: #29

* fix(ci): use nightly-2024-06-12
@andelf
Copy link
Contributor

andelf commented Jun 20, 2024

Added rust-toolchain.toml for a temporary workaround.

@sb-child
Copy link

sb-child commented Jul 7, 2024 •
edited
Loading

Another temporary workaround is:

# Cargo.toml
[patch.crates-io]
embassy-executor-macros = { git = 'https://github.com/embassy-rs/embassy' }

@lure23
Copy link

lure23 commented Jul 27, 2024 •
edited
Loading

A third way to work around:

$ cargo  nightly-2024-06-01 run --release

I prefer this, due to the problem likely being temporary in nature.

p.s. @jsprog my experience is that Embassy can be used with stable - though the instructions were still mentioning otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andelf @jsprog @sb-child @lure23