Issue 580 select ambiguous column name using the wheels alias #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new aliasedProperyList node in the classData which will have the specific columns prepended with the model name so that we can get the column in the select clause if include table is specified.
Changed condition to include all columns in the list as suggested by @chapmandu
|
@zainforbjs can you resolve the merge conflicts on this PR so it can be merged. |
|
@bpamiri I have resolved the conflicts. Please try to merge now. |
Due to the changes done in this branch, the other test cases need to be altered a little. Fixed that.
|
@bpamiri The PR is ready to merge, all tests have been passed. |
bpamiri
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new aliasedProperyList node in the classData which will have the specific columns prepended with the model name so that we can get the column in the select clause if include table is specified.
This is then compared with select argument's values and returns the correct column of the table.
A test case is also added which is copied from @chapmandu issue 580's description. Tested it as well and it is successful.