Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker compose updates #1200

Merged
merged 28 commits into from
Oct 10, 2022
Merged

Docker compose updates #1200

merged 28 commits into from
Oct 10, 2022

Conversation

chapmandu
Copy link
Contributor

@chapmandu chapmandu commented Oct 3, 2022 •
edited
Loading

  • Fixes typo in docker root volume name
  • Upgrade to docker compose
  • Comment out development volume.. it seems to break the github action
  • Remove volume /src/docker - it doesnt seem to be used
  • Remove 2 redundant workflow steps now that --wait option is available to docker compose
  • Fix BOX_SERVER_CFCONFIGFILE path to prevent commandbox exception

Original commit 5c844fb

@chapmandu chapmandu marked this pull request as draft October 4, 2022 03:45
@chapmandu chapmandu marked this pull request as ready for review October 4, 2022 04:53
@chapmandu chapmandu changed the title Fixes root docker volume typo Docker compose updates Oct 4, 2022
@bpamiri
Copy link
Collaborator

bpamiri commented Oct 10, 2022

Updated the Vue CLI version because the existing version was causing errors for building the test-ui app on Mac Intel and Mac M1. I also took the opportunity to update the Readme file with the new docker compose commands as well as more definition around the datasources created for the test runner. Lastly I added the URL of the test runner to the test-ui console output to make it easier for the user to copy the URL and run the tests manually.

@bpamiri bpamiri merged commit 0538e78 into cfwheels:develop Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapmandu @bpamiri