Rule to check for structNew and suggest using {} instead #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryaneberly
added a commit
that referenced
this pull request
Oct 12, 2015
Rule to check for structNew and suggest using {} instead
|
@justinmclean |
|
Does it understand / check that writedump take a parameter, where structnew doesn't? |
|
And I assume you've not merged in arraynew(1), as arraynew(1) can be replaced by [] but arraynew(2) can't. |
| final String cfmlFunctionCheck = getParameter("functionName"); | ||
|
|
||
| CFFunctionExpression functionExpression = (CFFunctionExpression)expression; | ||
| if(functionExpression.getName().equalsIgnoreCase(cfmlFunctionCheck)){ |
There was a problem hiding this comment.
may want to use cfmlFunctionCheck "(" so less chance of matching things that are not function calls?
|
Right, I didn't use this strategy for arraynew(1). I was going to, but one of the tests failed :-). cfmlFunctionCheck is the entire name. The grammar will not call it a function unless there is a parenthesis though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.