Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notification - 128.4.x #4934

Open
6 of 9 tasks
amaitland opened this issue Sep 20, 2024 · 2 comments
Open
6 of 9 tasks

Release Notification - 128.4.x #4934

amaitland opened this issue Sep 20, 2024 · 2 comments
Assignees
Milestone

Comments

@amaitland
Copy link
Member

amaitland commented Sep 20, 2024

Release 128.4.x

  • Create cefsharp/128 release branch
  • Update DevTools client API
  • Update to latest CEF build
  • Resolve remaining issues attached to 128 Milestone
  • Create release notes
  • Release stable packages to nuget.org
  • Update Issue Template CEF Sample application links
  • Generate new API Doc and upload to http://cefsharp.github.io/api/
  • Update General Usage API doc links
@amaitland amaitland added this to the 128.4.x milestone Sep 20, 2024
@amaitland
Copy link
Member Author

The Alloy Bootstrap has been removed (#4795)

There are multiple breaking changes. 19739ab

@amaitland amaitland self-assigned this Sep 20, 2024
@amaitland amaitland pinned this issue Sep 21, 2024
@kpreisser
Copy link
Contributor

Hi @amaitland, thanks for your work on releasing the new version!

I noticed that when using CefSharp.Wpf.HwndHost 127.3.50 together with the new version CefSharp.Common.NETCore 128.4.90, the Chrome style is always used for the ChromiumWebBrowser, e.g. the context menu shows entries for opening the developer tools, and new windows will have the full chrome appearance. This happens even when setting CefSharpSettings.RuntimeStyle = CefRuntimeStyle.Alloy.

I noticed this seems to be because ChromiumWebBrowser.CreateBrowserWindowInfo() in CefSharp.Wpf.HwndHost doesn't set the IWindowInfo.RuntimeStyle property:

        protected virtual IWindowInfo CreateBrowserWindowInfo(IntPtr handle)
        {
            var windowInfo = new WindowInfo();
            windowInfo.SetAsChild(handle);

            if (!ActivateBrowserOnCreation)
            {
                //Disable Window activation by default
                //https://bitbucket.org/chromiumembedded/cef/issues/1856/branch-2526-cef-activates-browser-window
                windowInfo.ExStyle |= WS_EX_NOACTIVATE;
            }

            return windowInfo;
        }

whereas e.g. the WinForms ChromiumWebBrowser sets it:

protected virtual IWindowInfo CreateBrowserWindowInfo(IntPtr handle)
{
var windowInfo = Core.ObjectFactory.CreateWindowInfo();
windowInfo.RuntimeStyle = CefSharpSettings.RuntimeStyle ?? CefRuntimeStyle.Alloy;
windowInfo.SetAsChild(handle);
if (!ActivateBrowserOnCreation)
{
//Disable Window activation by default
//https://github.com/chromiumembedded/cef/issues/1856/branch-2526-cef-activates-browser-window
windowInfo.ExStyle |= WS_EX_NOACTIVATE;
}
return windowInfo;
}

Is this something that needs to be done for a new CefSharp.Wpf.HwndHost release?
(In the meanwhile, I created a subclass of ChromiumWebBrowser in our application that overrides CreateBrowserWindowInfo and sets the runtime style, and now the alloy style is correctly used.)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants