Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHIL parsing: comments ! positioning #129

Open
stranskj opened this issue Jan 31, 2018 · 0 comments
Open

PHIL parsing: comments ! positioning #129

stranskj opened this issue Jan 31, 2018 · 0 comments
Assignees

Comments

@stranskj
Copy link

When exclamation mark (!) is used for comment, it cannot be separated by white spaces from a commented definition. It fails with RuntimeError: Syntax error: improper definition name ""
The problem is, that it can be well hidden and diffictult for user to track the error down.

Example:
Functional:

!input {
something = True
}

Not Functional:

! input {
something = True
}

https://github.com/cctbx/cctbx_project/blob/master/libtbx/phil/init.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants