fix: Player sources handling improvements #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccatterina
force-pushed
the
player-improvements
branch
from
028b29b
to
c706202
Compare
- Search and set the current player also when the preferred source name changes and not only when a new source is added. - Search among all the available sources to choose the player to set as the current one. - Set Plasmoid.status on `player.onReadyChanged` event. Apparently calculating Plasmoid.status using `player.ready` variable not always works. - Add debug log on events like current player change or player readyness change. Fix #60
ccatterina
force-pushed
the
player-improvements
branch
from
c706202
to
0844cbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
player.onReadyChangedevent. Apparently calculating Plasmoid.status usingplayer.readyvariable not always works.Fix #60