Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Separate lightAccent and darkAccent colors #900

Closed
2 tasks done
tmprnc opened this issue May 19, 2024 · 9 comments
Closed
2 tasks done

Feature request: Separate lightAccent and darkAccent colors #900

tmprnc opened this issue May 19, 2024 · 9 comments

Comments

@tmprnc
Copy link

tmprnc commented May 19, 2024

Is there an existing issue outlining your problem?

  • I am using the latest version of the provided userstyle.
  • I have searched the existing issues and they do not solve my problem.

What userstyles are you seeing the problem on?

All.

Describe your problem.

I have Twitter switch from light to dark theme based on Windows theme, which switches based on sunrise/sunset.
I love the green accent color on the dark palettes, because it's a beautiful pastel green. I do not like the dark saturated green of the Latte palette I use during daytime, though. I would like to be able to set Catppuccin for Twitter to use Latte Flamingo during the day and Mocha Green during the night. I'm sure there's a hacky way I could do this, such as changing the actual hex values in the lookup table, but I feel like that would be a rather unclean way to do this, and modifying the CSS myself would result in either them being broken every update, or conversely, depriving me of updates. I'm not familiar at all with CSS pre-processors, so my attempts to try and figure out how to change it more cleanly failed.

Attach screenshots.

No response

What browser(s) are you seeing the problem on?

Vivaldi 6.7.3329.31 (Stable channel) (64-bit)

Any additional comments?

No response

@github-actions github-actions bot added the twitter Twitter label May 19, 2024
@isabelroses
Copy link
Member

The largest issue with twitter, is that the webpage is full of inline styling. This makes it take a significant amount of time to create and maintain, adding a light mode would be nice but a very strenuous task.

@tmprnc
Copy link
Author

tmprnc commented May 19, 2024

The largest issue with twitter, is that the webpage is full of inline styling. This makes it take a significant amount of time to create and maintain, adding a light mode would be nice but a very strenuous task.

I don't understand. Catppuccin for Twitter already has a working "dark/light" mode switch going on. It just ignores Twitter's own theme choices and simply asks you to run blue color pure black Twitter, then rewrites the colors. Effectively, this is white theme being written over AMOLED black.

2024-05-19.11-34-50.mp4

What I'm asking is not about that. That already works. What I'm asking is to have separate accent colors (i.e. Rosewater for Latte WHEN the "light mode" toggle is on, and Green for Mocha when the "dark mode" toggle is on). I think if it is possible to completely change the entire theme on the fly based on system's light/dark mode setting, then it should be able to do so with the accent color also, right?

@isabelroses
Copy link
Member

Ahh, I understood it as a dark/light switcher and since the first thing I saw when moving to light mode was this
image

But it should be possible to do this. Curious whether its worth the effort though. I'd like to hear @uncenter views.

@tmprnc
Copy link
Author

tmprnc commented May 19, 2024

I should mention that I incorrectly believed I was using the latest version of the userstyle. Since I tried to make changes to it, it disabled automatic updates, most likely. The newest version doesn't have the feature I'm requesting either, but I should have checked before I hit the tickbox.

@uncenter
Copy link
Member

Ahh, I understood it as a dark/light switcher and since the first thing I saw when moving to light mode was this image

But it should be possible to do this. Curious whether its worth the effort though. I'd like to hear @uncenter views.

I mean it is a lot more work for both updating all 80-something userstyles and just more confusing options for users to pick from. Seeing as you are the first person to request this, maybe we leave this open for a little while and see if others also want this?

@uncenter uncenter removed the twitter Twitter label Jun 30, 2024
@uncenter uncenter changed the title Feature request: Separate accent colors for day and night theme Feature request: Separate lightAccent and darkAccent colors Jun 30, 2024
@uncenter uncenter pinned this issue Jun 30, 2024
@trinkey
Copy link
Contributor

trinkey commented Aug 1, 2024

I 2 this feature request, and it shouldn't be difficult at all to do:
image

@uncenter
Copy link
Member

uncenter commented Aug 1, 2024

@trinkey it's pretty clearly not about the difficulty, as we know we already have dark and light flavor options. The question is how often will people use this? If only 10/1000 people want to use this, the other 990 have to then change two dropdowns just to change their accent color if they want it the same for both. How much additionally complexity are we wanting to introduce? Making this change happen is difficult with over a hundred userstyles now. This will also break existing setups and we can't easily migrate users.

@kerichdev
Copy link
Member

i -1 this tbh, it seems like a... niche request, albeit not THAT hard to implement, it introduces extra switches, and on a scale of all the userstyles, is still a massive effort.

it could be a docs-worthy mention on how to implement it yourself, if you REALLY need it, that's my opinion 🤷

@uncenter
Copy link
Member

I'm going to close this as not planned for now, though I don't think including this in the docs would be wise either; the usage instructions are already pretty complicated and I don't want to add more confusion/complexity, let alone how annoying it would be to change this across all the userstyles you use 😃

@uncenter uncenter closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2024
@sgoudham sgoudham unpinned this issue Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants