Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Theme channels & roles #314

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Fix: Theme channels & roles #314

merged 4 commits into from
Sep 13, 2024

Conversation

DokterKaj
Copy link
Contributor

@DokterKaj DokterKaj commented Aug 5, 2024

div[class*="pageBody_"] is required to properly theme the Browse Channels tab.

As far as I can tell, the only thing that div[class*="content_"][class*="container_"] { div[class*="container"] } affects is the box around dropdowns in the Customise tab, so I've changed it to match the background colour of those prompts.

Closes #312

@DokterKaj
Copy link
Contributor Author

Server Guide, Channels & Roles page, and forums should all use the same background and card colours
Right now, Server Guide and forums use $base for background and $surface0 for cards
This fix just reveals the CSS that was already there for Channels & Roles, which used $mantle for background and $base for cards
I won't close this PR right now but in the future this should be fixed to align with the other two

@ToxicAven
Copy link
Collaborator

If this PR has no intention of being merged currently, please mark it as a draft PR.

@DokterKaj DokterKaj marked this pull request as draft August 7, 2024 01:51
@DokterKaj DokterKaj closed this Sep 3, 2024
@DokterKaj DokterKaj deleted the patch-2 branch September 3, 2024 15:19
@DokterKaj DokterKaj restored the patch-2 branch September 3, 2024 15:19
@DokterKaj DokterKaj reopened this Sep 3, 2024
@DokterKaj DokterKaj marked this pull request as ready for review September 13, 2024 17:54
@DokterKaj
Copy link
Contributor Author

Basically there was no need to overcomplicate things, the variable --home-background themes all of the background. I've themed the background to $base and cards to $surface0 to keep consistency with the server guide, as well as lightened the selected parts from $crust to $mantle so they don't stand out as much. The main problem is the hover colour for channels; it should be darker than the card ($surface0) but lighter than the background ($base) but no such colour exists in the palette. I've themed it to $base for now but suggestions are welcome.

@ToxicAven ToxicAven merged commit e14e442 into catppuccin:main Sep 13, 2024
@DokterKaj DokterKaj deleted the patch-2 branch September 13, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channels & Roles background not themed
2 participants