On start up wait invoice returns all paid invoices #430

thesimplekid · 2024-10-30T22:08:56Z

On start up since we do not pass the wait index to start at wait_any_invoice returns all the invoices that have been paid on the node. We should try and avoid this. And with the addition of bolt 12 we need to make sure we are not adding to the amount thats been paid more then once per real payment.

cdk/crates/cdk-cln/src/lib.rs

Lines 101 to 118 in 4fdc4f4

    
           // Clippy thinks select is not stable but it compiles fine on MSRV (1.63.0) 
        
           async fn wait_any_invoice( 
        
               &self, 
        
           ) -> Result<Pin<Box<dyn Stream<Item = String>   Send>>, Self::Err> { 
        
               let last_pay_index = self.get_last_pay_index().await?; 
        
               let cln_client = cln_rpc::ClnRpc::new(&self.rpc_socket).await?; 
        
               let stream = futures::stream::unfold( 
        
                   ( 
        
                       cln_client, 
        
                       last_pay_index, 
        
                       self.wait_invoice_cancel_token.clone(), 
        
                       Arc::clone(&self.wait_invoice_is_active), 
        
                   ), 
        
                   |(mut cln_client, mut last_pay_idx, cancel_token, is_active)| async move { 
        
                       // Set the stream as active 
        
                       is_active.store(true, Ordering::SeqCst);

mubarak23 · 2024-11-06T10:16:09Z

so, on startup, we return only unpaid invoice @thesimplekid

thesimplekid self-assigned this Nov 15, 2024

thesimplekid mentioned this issue Nov 15, 2024

Bolt12 with support for multiple payments per mint quote #404

Draft

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

On start up wait invoice returns all paid invoices #430

On start up wait invoice returns all paid invoices #430

thesimplekid commented Oct 30, 2024

mubarak23 commented Nov 6, 2024

On start up wait invoice returns all paid invoices #430

On start up wait invoice returns all paid invoices #430

Comments

thesimplekid commented Oct 30, 2024

mubarak23 commented Nov 6, 2024