-
-
Notifications
You must be signed in to change notification settings - Fork 22
/
fixture.ts.lint
153 lines (143 loc) · 3.47 KB
/
fixture.ts.lint
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
import { Component, OnDestroy } from "@angular/core";
import { of, Subject } from "rxjs";
import { switchMap, takeUntil } from "rxjs/operators";
const a = of("a");
const b = of("b");
const c = of("c");
const d = of("d");
@Component({
selector: "correct-component"
})
class CorrectComponent implements OnDestroy {
private destroy = new Subject<void>();
someMethod() {
a.pipe(
switchMap(_ => b),
takeUntil(this.destroy)
).subscribe();
}
ngOnDestroy() {
this.destroy.next();
this.destroy.complete();
}
}
@Component({
selector: "destructured-component"
})
class DestructuredComponent implements OnDestroy {
private destroy = new Subject<void>();
someMethod() {
const { destroy } = this;
a.pipe(
switchMap(_ => b),
takeUntil(destroy)
).subscribe();
}
ngOnDestroy() {
const { destroy } = this;
destroy.next();
destroy.complete();
}
}
@Component({
selector: "no-takeuntil-component"
})
class NoTakeUntilComponent {
private destroy = new Subject<void>();
someMethod() {
const { destroy } = this;
a.pipe(
switchMap(_ => b)
).subscribe();
~~~~~~~~~ [prefer-takeuntil]
}
ngOnDestroy() {
this.destroy.next();
this.destroy.complete();
}
}
@Component({
selector: "no-subject-component"
})
class NoSubjectComponent implements OnDestroy {
~~~~~~~~~~~~~~~~~~ [prefer-takeuntil-no-subject % ('d')]
someMethod() {
const { destroy } = this;
a.pipe(
switchMap(_ => b),
takeUntil(d)
).subscribe();
}
ngOnDestroy() {
~~~~~~~~~~~ [prefer-takeuntil-no-next % ('d')]
~~~~~~~~~~~ [prefer-takeuntil-no-complete % ('d')]
}
}
@Component({
selector: "secondary-takeuntil-component"
})
class SecondaryTakeUntilComponent implements OnDestroy {
private destroy = new Subject<void>();
someMethod() {
a.pipe(
takeUntil(c),
switchMap(_ => b),
takeUntil(this.destroy)
).subscribe();
}
ngOnDestroy() {
this.destroy.next();
this.destroy.complete();
}
}
@Component({
selector: "no-destroy-component"
})
class NoDestroyComponent {
~~~~~~~~~~~~~~~~~~ [prefer-takeuntil-no-destroy]
private destroy = new Subject<void>();
someMethod() {
const { destroy } = this;
a.pipe(
switchMap(_ => b),
takeUntil(destroy)
).subscribe();
}
}
@Component({
selector: "no-next-component"
})
class NoNextComponent implements OnDestroy {
private destroy = new Subject<void>();
someMethod() {
a.pipe(
switchMap(_ => b),
takeUntil(this.destroy)
).subscribe();
}
ngOnDestroy() {
~~~~~~~~~~~ [prefer-takeuntil-no-next % ('destroy')]
this.destroy.complete();
}
}
@Component({
selector: "no-complete-component"
})
class NoCompleteComponent implements OnDestroy {
private destroy = new Subject<void>();
someMethod() {
a.pipe(
switchMap(_ => b),
takeUntil(this.destroy)
).subscribe();
}
ngOnDestroy() {
~~~~~~~~~~~ [prefer-takeuntil-no-complete % ('destroy')]
this.destroy.next();
}
}
[prefer-takeuntil]: Subscribing without takeUntil is forbidden
[prefer-takeuntil-no-subject]: Subject '%s' not a class property
[prefer-takeuntil-no-destroy]: ngOnDestroy not implemented
[prefer-takeuntil-no-next]: '%s.next()' not called
[prefer-takeuntil-no-complete]: '%s.complete()' not called