Expose indexing as a language interface #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for some reason `clang-format` makes this unnecessary changes to the comments
brymer-meneses
changed the title
|
I think this should be ready for review. The bulk of the test happens at |
jonmeow
reviewed
Oct 25, 2024
Co-authored-by: Jon Ross-Perkins <[email protected]>
Co-authored-by: Jon Ross-Perkins <[email protected]>
Co-authored-by: Jon Ross-Perkins <[email protected]>
Co-authored-by: Jon Ross-Perkins <[email protected]>
brymer-meneses
force-pushed
the
index-with
branch
2 times, most recently
from
e2dc087
to
8ea0a6b
Compare
brymer-meneses
force-pushed
the
index-with
branch
from
8ea0a6b
to
4f9702d
Compare
|
Thanks for the changes! It looks though like there are still test failures on toolchain/check/testdata/class/fail_redeclaration_introducer.carbon -- where did that file come from? It appears to be unrelated to the indexing change, should it be removed? |
|
I'm also not sure, perhaps i messed up syncing to trunk again--sorry about that! |
|
Not really sure why are the tests failing :<< |
auto-merge was automatically disabled
October 29, 2024 18:40
Head branch was pushed to by a user without write access
|
My bad, forgot to add |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
This is in particular to avoid churn from changes such as #4370. I think the import list can be helpful (particularly to understand what the library is aware of), but it's a different trade-off for the prelude package due to the implicit imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that types can implement the
IndexWithinterface so that they can provide their custom indexing behavior.