Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instructions for adding a SemIR instruction. #4348

Merged
merged 16 commits into from
Oct 10, 2024
Merged

Update instructions for adding a SemIR instruction. #4348

merged 16 commits into from
Oct 10, 2024

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Sep 26, 2024

No description provided.

jonmeow
jonmeow reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're still making changes to this PR. I assume you won't be done with it soon, I'll note I go on vacation tomorrow so you might want to find another reviewer to finish.

toolchain/docs/adding_features.md Outdated Show resolved Hide resolved
toolchain/docs/adding_features.md Outdated Show resolved Hide resolved
toolchain/docs/adding_features.md Outdated Show resolved Hide resolved
toolchain/docs/adding_features.md Outdated Show resolved Hide resolved
toolchain/docs/adding_features.md Outdated Show resolved Hide resolved
toolchain/docs/adding_features.md Outdated Show resolved Hide resolved
toolchain/docs/adding_features.md Outdated Show resolved Hide resolved
@josh11b josh11b requested a review from zygoloid October 1, 2024 05:21
@josh11b
Copy link
Contributor Author

josh11b commented Oct 1, 2024

@zygoloid Could you help me figure out the right changes to make to the text to address these comments?

@josh11b josh11b requested review from jonmeow and removed request for zygoloid October 9, 2024 22:29
jonmeow
jonmeow reviewed Oct 10, 2024
View reviewed changes
toolchain/docs/adding_features.md Outdated Show resolved Hide resolved
toolchain/docs/adding_features.md Outdated Show resolved Hide resolved
toolchain/docs/adding_features.md Outdated Show resolved Hide resolved
josh11b
josh11b commented Oct 10, 2024
View reviewed changes
Copy link
Contributor Author

@josh11b josh11b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied your suggestions

jonmeow
jonmeow approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jonmeow jonmeow added this pull request to the merge queue Oct 10, 2024
Merged via the queue into carbon-language:trunk with commit 9e5e330 Oct 10, 2024
8 checks passed
@josh11b josh11b deleted the semirdoc branch October 10, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarbonInfraBot CarbonInfraBot CarbonInfraBot left review comments

@jonmeow jonmeow jonmeow approved these changes

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh11b @jonmeow @CarbonInfraBot