Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish toolchain and language versioning #4105

Merged
merged 7 commits into from
Jul 14, 2024

Conversation

chandlerc
Copy link
Contributor

@chandlerc chandlerc commented Jul 2, 2024

Proposal for how Carbon version numbers work:

  • A single version across language, standard library, compiler, linker, etc.
  • Semantic Versioning (SemVer) based
  • Details of how SemVer criteria for major, minor, and patch should apply to
    Carbon
  • Details of how we will operate before 1.0 and how this connects to Carbon's
    milestones
  • Directional guidance for future work including post-1.0 versions, LTS
    versions, and standardization

@chandlerc chandlerc added proposal A proposal proposal draft Proposal in draft, not ready for review labels Jul 2, 2024
@chandlerc chandlerc changed the title Toolchain and language versioning Establishing toolchain and language versioning Jul 2, 2024
@chandlerc chandlerc changed the title Establishing toolchain and language versioning Establish toolchain and language versioning Jul 2, 2024
@chandlerc chandlerc marked this pull request as ready for review July 2, 2024 23:42
@github-actions github-actions bot added proposal rfc Proposal with request-for-comment sent out and removed proposal draft Proposal in draft, not ready for review labels Jul 2, 2024
@github-actions github-actions bot requested a review from KateGregory July 2, 2024 23:43
@github-actions github-actions bot added the documentation An issue or proposed change to our documentation label Jul 2, 2024
@chandlerc chandlerc requested a review from zygoloid July 3, 2024 23:50
@chandlerc
Copy link
Contributor Author

Ping.

Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. While I have a few comments, they're mostly around the presentation rather than the rules; the only real non-cosmetic question is whether we still want the -0. in nightly and dev versions now that it's not necessary to get them to sort before -alpha and -beta.

docs/project/versioning.md Outdated Show resolved Hide resolved
docs/project/versioning.md Outdated Show resolved Hide resolved
Comment on lines 46 to 53
- `MAJOR.MINOR.PATCH-rc.N`: The N-th potentially viable candidate for a
release.
- `MAJOR.MINOR.PATCH-0.nightly.YYYY.MM.DD`: A nightly incremental
development build on a particular day during development of that
version.
- `MAJOR.MINOR.PATCH-0.dev`: An interactive, incremental development build
on a particular day by some developer during development of that
version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we don't have -alpha and -beta here, it seems that we don't need the -0. prefix to ensure that dev and nightly are ordered before rc. Would it make sense to remove the 0. part? (We could add it back in future if we add back alpha / beta.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to do this... It seems nice to have nightly and dev be more explicitly separate categories from rc or anything else we have here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I don't have a strong opinion. And maybe relying on the coincidence that dev and nightly collate before rc is too "clever".

docs/project/versioning.md Outdated Show resolved Hide resolved
docs/project/versioning.md Outdated Show resolved Hide resolved
docs/project/versioning.md Outdated Show resolved Hide resolved
proposals/p4105.md Outdated Show resolved Hide resolved
proposals/p4105.md Outdated Show resolved Hide resolved
proposals/p4105.md Outdated Show resolved Hide resolved
proposals/p4105.md Outdated Show resolved Hide resolved
@chandlerc chandlerc requested a review from zygoloid July 14, 2024 03:40
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chandlerc chandlerc added this pull request to the merge queue Jul 14, 2024
Merged via the queue into carbon-language:trunk with commit 2fcff24 Jul 14, 2024
7 checks passed
@chandlerc chandlerc deleted the rfc-version branch July 14, 2024 06:31
github-merge-queue bot pushed a commit that referenced this pull request Jul 15, 2024
With this our infrastructure should match the final form of proposal
#4105 that established our versioning scheme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation An issue or proposed change to our documentation proposal rfc Proposal with request-for-comment sent out proposal A proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants