Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIShell components: rename "isOpen" prop to "open" #1876

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

UIShell components: rename "isOpen" prop to "open" #1876

wants to merge 3 commits into from

Conversation

daviseidel
Copy link

Solving issue #461, it will bring more consistency, as now all components use open prop instead of isOpen

theetrain
theetrain reviewed Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@theetrain theetrain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, overall this works and helps with #1621

When you have a moment, please update parts in /docs where UIShell is used with the open prop, and generated docs:

  • Run yarn build:docs and yarn build:lib
  • /docs/src/pages/framed/UIShell/ examples
  • docs/src/pages/_layout.svelte
  • Anywhere else UIShell components are used

@daviseidel
Copy link
Author

Fixed all instances I could find. Tell me if I missed any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theetrain theetrain theetrain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviseidel @theetrain