Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icons library URL #17251

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Update Icons library URL #17251

merged 5 commits into from
Aug 30, 2024

Conversation

wjason94ibm
Copy link
Contributor

Updated in packages/icons-react/README.md non-working Icons library link (https://www.carbondesignsystem.com/guidelines/iconography/library) to working link (https://carbondesignsystem.com/elements/icons/library)

Changelog

Changed

Testing / Reviewing

  1. Go to non-working link https://www.carbondesignsystem.com/guidelines/iconography/library and verify that it shows a 404 page
  2. Go to working link https://carbondesignsystem.com/elements/icons/library and verify that it displays all of the icons in carbon/icons-react library.

@wjason94ibm wjason94ibm requested a review from a team as a code owner August 22, 2024 18:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2024 •
edited
Loading

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@wjason94ibm
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7de4983
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66d23fc32856850008777f4d
😎 Deploy Preview https://deploy-preview-17251--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7de4983
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66d23fc3a9f037000849024b
😎 Deploy Preview https://deploy-preview-17251--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tay1orjones
tay1orjones approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kennylam kennylam added this pull request to the merge queue Aug 30, 2024
Merged via the queue into carbon-design-system:main with commit 0a5f383 Aug 30, 2024
23 checks passed
@wjason94ibm wjason94ibm deleted the patch-1 branch September 3, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@2nikhiltom 2nikhiltom 2nikhiltom approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjason94ibm @kennylam @tay1orjones @2nikhiltom