Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overflowmenu): always use button kind=ghost #16970

Merged
merged 9 commits into from
Aug 2, 2024
Merged

fix(overflowmenu): always use button kind=ghost #16970

merged 9 commits into from
Aug 2, 2024

Conversation

tay1orjones
Copy link
Member

Closes #16836

This enforces the design spec for OverflowMenu:

Overflow menu has the ghost button style only

Changelog

Changed

  • Add kind="ghost" to OverflowMenu
  • Add kind="ghost" to next/OverflowMenu (behind feature flag)

Testing / Reviewing

  • There should be no visible changes to OverflowMenu stories
  • There should be no visible changes to the feature flagged OverflowMenu stories
  • I confirmed this fix based on the stackblitz example from the original issue. Adding kind="ghost" solves it.

@tay1orjones tay1orjones requested a review from a team as a code owner July 16, 2024 18:09
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 3804036
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66ad0290ef7fa1000803ceee
😎 Deploy Preview https://deploy-preview-16970--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3804036
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66ad02909754880008afd40c
😎 Deploy Preview https://deploy-preview-16970--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alisonjoseph
alisonjoseph approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for adding the test 😃 (I think it just needs a snapshot update?)

@guidari guidari enabled auto-merge July 26, 2024 12:31
@guidari guidari added this pull request to the merge queue Aug 2, 2024
Merged via the queue into carbon-design-system:main with commit 796f838 Aug 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@riddhybansal riddhybansal riddhybansal approved these changes

@guidari guidari guidari approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: OverflowMenu styles overridden by Button
4 participants
@tay1orjones @alisonjoseph @riddhybansal @guidari