Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(accordion): support nested accordion #16933

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(accordion): support nested accordion #16933

wants to merge 5 commits into from
112 −4

Conversation

tekno0ryder
Copy link

Closes #16732

Support rare case of using nested accordions

Changelog

Changed

  • Changed active css selector from descendant combinator that targets all descendants regardless of their level to child combinator (>) that targets only the direct children.

Testing / Reviewing

  • Unit test: Expanding parent shouldn't expand children accordion Expand children works
  • Video
Screen.Recording.2024-07-09.at.11.45.40.PM.mov

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 42d4476
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/668daa42a136e60008551a88
😎 Deploy Preview https://deploy-preview-16933--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 42d4476
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/668daa42c81b330008f5d5ba
😎 Deploy Preview https://deploy-preview-16933--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6af391c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/669e2a5627f01e00082d1aee
😎 Deploy Preview https://deploy-preview-16933--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6af391c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/669e2a566c205b000798f350
😎 Deploy Preview https://deploy-preview-16933--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tekno0ryder
Copy link
Author

I have read the DCO document and I hereby sign the DCO.

@tekno0ryder tekno0ryder marked this pull request as ready for review July 10, 2024 13:30
@tekno0ryder tekno0ryder requested a review from a team as a code owner July 10, 2024 13:30
@Gururajj77
Copy link
Contributor

Hey @tekno0ryder ! thanks for your contribution, could you please setup a test story, that can be excluded later if we approve it??

@tekno0ryder
Copy link
Author

Hey @tekno0ryder ! thanks for your contribution, could you please setup a test story, that can be excluded later if we approve it??

Hi! please find preview story here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@guidari guidari Awaiting requested review from guidari guidari is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Child accordion's expand/collapse not working
3 participants
@tekno0ryder @Gururajj77 @2nikhiltom