-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FilterableMultiSelect): assign given id
to the listbox
#16917
Merged
guidari
merged 2 commits into
carbon-design-system:main
from
cuppajoey:filterablemultiselect-id
Jul 26, 2024
Merged
feat(FilterableMultiSelect): assign given id
to the listbox
#16917
guidari
merged 2 commits into
carbon-design-system:main
from
cuppajoey:filterablemultiselect-id
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pass the existing `id` prop to the rendered `ListBox` for parity with `MultiSelect`.
cuppajoey
force-pushed
the
filterablemultiselect-id
branch
from
July 5, 2024 16:30
39384f0
to
abb0188
Compare
guidari
approved these changes
Jul 8, 2024
Thanks for the contribution! |
Gururajj77
approved these changes
Jul 16, 2024
riddhybansal
approved these changes
Jul 23, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jul 26, 2024
d755f2c
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
FilterableMultiSelect
does not assign itsid
prop to any rendered element making that prop mostly useless for consumers. While it does use theid
to create ids for descendant elements; this is inconsistent withMultiSelect
which does assign itsid
prop to the list box container.This discrepancy can be observed in the Carbon storybook:
Changelog
New
id
prop to the renderedListBox
for parity withMultiSelect
.id
.Testing / Reviewing
FilterableMultiSelect
playground..cds--multi-select
class and confirmid
attribute is assigned the given value.