Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook 8 #16910

Merged
merged 65 commits into from
Aug 30, 2024
Merged

Storybook 8 #16910

merged 65 commits into from
Aug 30, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jul 3, 2024 •
edited
Loading

Closes #16468

Storybook 8 is coming 🚀

Changelog

New

  • Upgrade Storybook from 7.1.0 to 8.1.10
  • Added @storybook/addon-webpack5-compiler-babel

Changed

  • ArgsTable Doc block replace by ArgTypes on .mdx files. | docs
  • <Story of={componentStory} /> replace by <Canvas of={componentStory} /> | docs
  • Switch @storybook/addons for @storybook/manager-api | docs
  • Fixed imports in packages/react/src/index.js

Removed

  • Removed the babelLoader.exclude since there is no need anymore for that.

References:

Testing / Reviewing

Pull down locally

yarn install
yarn build
yarn storybook

  • Please test all things in storybook 🙏🏻, docs, playground controls, skeleton, default stories, feature flags, actions...
  • Make sure we still have all the functionalities we used to have on v7.
    Should all be running smoothly and let me know of any issues.
  • CI should pass

@netlify Netlify
Copy link

netlify bot commented Jul 3, 2024 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0e2e1ee
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66d1b2152fa9aa0008bbfebd
😎 Deploy Preview https://deploy-preview-16910--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari changed the title feat: added storybook 8 and vite builder WIP: Storybook 8 Jul 3, 2024
@guidari guidari mentioned this pull request Jul 4, 2024
Closed
1 task
@guidari
Copy link
Contributor Author

guidari commented Jul 12, 2024

The only missing thing to fix is this "Sourcemap" issue that I'm trying to find a solution. Other than that I think this looks good to review.
Screenshot 2024-07-12 at 16 49 57

@guidari guidari changed the title WIP: Storybook 8 Storybook 8 Jul 12, 2024
@guidari guidari marked this pull request as ready for review July 12, 2024 19:51
@guidari guidari requested a review from a team as a code owner July 12, 2024 19:51
@tay1orjones
Copy link
Member

@guidari someone opened an issue for what seems like the same thing: storybookjs/storybook#28567

@tay1orjones
Copy link
Member

tay1orjones commented Jul 15, 2024 •
edited
Loading

@guidari also the deploy previews are failing due to what appears to be __DEV__ being undefined in production (IIRC deploy previews are considered a production environment) https://app.netlify.com/sites/v11-carbon-react/deploys/66917f1dc9a2210008441725

@guidari guidari requested a review from a team as a code owner July 18, 2024 17:49
tay1orjones
tay1orjones reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't merge this until the Percy failures are resolved. #16582 should fix it though by waiting for the story to be loaded and rendered. I'll try to get eyes on that PR and merge it asap so we can get this in.

This was referenced Aug 21, 2024
Closed
Merged
@guidari
Copy link
Contributor Author

guidari commented Aug 26, 2024 •
edited
Loading

@kennylam @tay1orjones
I guess we can approve this Percy now. After merging the toContainAStory the Percy failing that was blocking us is not a problem anymore.

@kennylam
Copy link
Member

Yep, snapshots all look good. Although I can't tell if the updated snapshots are correct or not. Looks like some spacing changes and gradient removal?

@guidari
Copy link
Contributor Author

guidari commented Aug 26, 2024

@kennylam
Yeah, there is something wrong with the spacing. I'm gonna check to see what is going on

@guidari guidari mentioned this pull request Aug 27, 2024
Open
@guidari guidari requested a review from a team as a code owner August 28, 2024 19:22
tay1orjones
tay1orjones approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for all your hard work on this!

@tay1orjones tay1orjones added this pull request to the merge queue Aug 30, 2024
Merged via the queue into carbon-design-system:main with commit 009351a Aug 30, 2024
23 checks passed
@tay1orjones tay1orjones mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees

@tay1orjones tay1orjones

@guidari guidari

Labels
status: one more review 👀 status: ready for review 👀
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Storybook to v8
3 participants
@guidari @tay1orjones @kennylam