Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nested checkbox #16731

Closed
wants to merge 6 commits into from
Closed

Conversation

Tresau
Copy link
Contributor

@Tresau Tresau commented Jun 10, 2024

Closes #12434

creates a new component called <NestedCheckbox/> that allows the user to control a group of checkbox from a single parent checkbox

Changelog

New

  • the NestedCheckbox component

Changed

  • Checkbox story documentation

Removed

  • N/A

Testing / Reviewing

ensure that the unit tests run properly. Ensure that the Nested section of the checkbox on the stories runs correctly. Ensure the overview runs and the documentation for NestedCheckbox is there and accurate.

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit be18b21
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6683f3254aaa4e0008991556
😎 Deploy Preview https://deploy-preview-16731--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit be18b21
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6683f32562908c000885f4f0
😎 Deploy Preview https://deploy-preview-16731--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tresau
Copy link
Contributor Author

Tresau commented Jun 13, 2024

Currently working on a bug where parent nested checkboxes do not always reflect the correct state of child nested checkboxes.
image
this is happening because changing from checked or unchecked to indeterminate does not fire an onChange event, I have a couple ideas on how to address this and will test them out.

@tay1orjones
Copy link
Member

Hey, thanks again for all your work here! It's been a couple months since there was movement here. In the interest of keeping the PR queue focused on actionable in progress items I'm going to close this PR for now.

If/when you're ready to pick this back up feel free to reopen this PR or open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Checkbox]: Nested implementation
2 participants