Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby apps support #45

Merged
merged 5 commits into from
Jan 8, 2018
Merged

Ruby apps support #45

merged 5 commits into from
Jan 8, 2018

Conversation

juanfrnz
Copy link
Contributor

Add support for ruby apps built on Rack.

Added dockerfile for ruby apps with some extra apk dependencies for building bundled native libraries.
Added new entry in TemplateHelper for ruby and sample app.

@githubsaturn
Copy link
Collaborator

@juanantoniofj
This is great! Thanks for adding this. Just some questions

  • I noticed that you're using rackup command, do ruby projects always support this command?
  • Based on my 30sec googling, there is a RACK_ENV environmental variable that needs to be set to production. Also, in case of Rails, there is RAILS_ENV. Don't we have to set these values?

Disclaimer: I haven't written a single line of Ruby. So my question might be too dumb, but I want to make sure that this is as generic as possible - without any presumptions about the project.

@juanfrnz
Copy link
Contributor Author

Thanks! I am not a Ruby expert either but i decided to give it a chance, so maybe someone can help us to clarify. Anyway, regarding your questions:

  • To support the rackup command, the Rack gem has to be installed. I wrote the template using the python template as guideline which is indeed based on Django. Maybe we should rename this template to "rack" instead "ruby"?
  • About the RACK_ENV, you are right, we have to set that ENV variable. I will add it.

@githubsaturn
Copy link
Collaborator

Ok thanks. I try to get hold of someone with Ruby experience to review this.
Cheers

@geoman2
Copy link

geoman2 commented Dec 18, 2017

Hello @githubsaturn

Want to send a feature request, is there a way to add the Vulcan JS framework (some sort of Meteor/ReactJS MongoDB stack) to captainduckduck

Sacha Greif is the author https://blog.vulcanjs.org/@sachagreif

Regards
Geo

@gnuns
Copy link
Contributor

gnuns commented Jan 6, 2018

Renaming this template to "rack" or "ruby-rack" instead of "ruby" is a good idea.
For Ruby on Rails, a puma template would be nice too.

@juanfrnz
Copy link
Contributor Author

juanfrnz commented Jan 6, 2018

I agree, @gnuns . I think ruby-rack would be a better choice, so it would start to set a naming convention for future use for new ruby templates.

@githubsaturn, would you consider a good choice to rename other templates like the python one to something like python-django?

@githubsaturn
Copy link
Collaborator

Great suggestion guys!

I'll merge this tomorrow and rename the templates. Expect this in v0.5 in next few days! 👍

@githubsaturn githubsaturn merged commit bee43e0 into caprover:master Jan 8, 2018
@zmd94
Copy link

zmd94 commented Nov 28, 2018

Just want to confirm that Ruby on Rails app can be deployed in CPP. Thank you for the support. I'm really appreciate it.

#324 How to Configure Ruby on Rails App

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants