chore: [#1213] Replaces rm rf with a windows compatible script when building #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capricorn86
requested changes
Jan 15, 2024
btea
force-pushed
the
task/use-rimraf-to-replace-rm-rf
branch
from
e74f384
to
ba307e6
Compare
|
rimraf pulls in 27 dependencies, so is generally nice to avoid: https://npmgraph.js.org/?q=rimraf you can do this as a nicer alternative: |
btea
force-pushed
the
task/use-rimraf-to-replace-rm-rf
branch
from
ba307e6
to
52487a2
Compare
Thanks for the solution, it looks great. 👍 |
btea
changed the title
capricorn86
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Thank you for your contribution @btea! 🌟
Sorry that you had to wait for such a long time to get this in.
|
Thank you for all your hard work. 👍 |
capricorn86
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.