Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 001-English-words-spelling-suggestions.yml #36

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

evilnick
Copy link
Contributor

Some of the words in the list are actually valid uses and I blame myself for not spotting them at the time

@@ -59,7 58,6 @@ swap:
'kilometer': kilometre
'labeled': labelled
'labor': labour
'license': licence
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noun/verb

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this the first round. The noun / verb usage needs context to validate, unfortunately.

@@ -72,7 70,6 @@ swap:
'parlor': parlour
'percent': per cent
'plow': plough
'practice': practise
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noun/verb

@@ -94,7 91,6 @@ swap:
'urbanization': urbanisation
'virtualize': virtualise
'virtualization': virtualisation
'whiskey': whisky
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

! Whiskey is the proper way to spell it!
Both are valid in UK English actually and are technically different drinks (whiskey is usually triple distilled and blended).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also not the most relevant word for documentation I reckon ... 😄

@@ -30,7 30,6 @@ swap:
'defense': defence
'dialed': dialled
'dialer': dialler
'dialog': dialogue
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annoying though it is 'dialog' is used in lots of GUI tools and I think it's just likely to cause pain and confusion if we try and enforce

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. "Dialog" is very common.

@evilnick
Copy link
Contributor Author

Fixes #33

@@ -94,7 91,6 @@ swap:
'urbanization': urbanisation
'virtualize': virtualise
'virtualization': virtualisation
'whiskey': whisky
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also not the most relevant word for documentation I reckon ... 😄

@evilnick evilnick merged commit fba369d into main Jun 13, 2024
@evilnick evilnick deleted the evilnick-updates branch June 13, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants