Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attributes value in Tensor Sources #20

Merged
merged 4 commits into from
Oct 21, 2015
Merged

Conversation

hobbeswalsh
Copy link
Contributor

@calston

Hey there, I don't know how this escaped me; some checks might need to share a Source but have different attributes defined. This patch allows the user to specify arbitrary attributes per check:

# ... etc ...
sources:

  - service: cpu
    source: tensor.sources.linux.basic.CPU
    attributes:
      key1: val1
      key2: val2

  - service: disk_free
    source: tensor.sources.linux.basic.DiskFree
    attributes:
      key1: val3

Thanks, and sorry for leaving this out of the last PR!

@hobbeswalsh
Copy link
Contributor Author

Let me know whether or not you think the version bump is necessary here. Thanks!

calston added a commit that referenced this pull request Oct 21, 2015
Allow `attributes` value in Tensor Sources
@calston calston merged commit fcf79fc into calston:master Oct 21, 2015
@hobbeswalsh
Copy link
Contributor Author

@calston Thanks. Let me know if there's anything I can do to make it easier for you to publish these commits to PyPI.

@hobbeswalsh
Copy link
Contributor Author

@calston were you planning on pushing this point release to PyPi?

Thanks!

@calston
Copy link
Owner

calston commented Oct 26, 2015

Sorry, missed the sdist in the release. Fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants