-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type in webhook payload #15912
Merged
Merged
fix: type in webhook payload #15912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
dosubot
bot
added
webhooks
area: webhooks, callback, webhook payload
🐛 bug
Something isn't working
labels
Jul 25, 2024
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (07/25/24)1 reviewer was added to this PR based on Keith Williams's automation. |
hariombalhara
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
I think we should have a function to generate the calendar event that accepts just booking
and derive everything from it.
zomars
pushed a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: CarinaWolli <[email protected]>
zomars
added a commit
that referenced
this pull request
Oct 4, 2024
* WIP: Billing service * WIP * Update __handler.ts * Update index.ts * WIP * WIP Signed-off-by: zomars <[email protected]> * WIP Signed-off-by: zomars <[email protected]> * Update delete.handler.ts * Update delete.handler.ts * Update internal-team-billing.ts * WIP * Type fixes Signed-off-by: zomars <[email protected]> * WIP Signed-off-by: zomars <[email protected]> * Discard changes to apps/api/v2/src/ee/event-types/event-types_2024_04_15/controllers/event-types.controller.ts * Discard changes to packages/app-store/skype/config.json * style: update text area (#15934) * chore: update text-editor input * chore: update text-editor input * final update * Update Editor.tsx --------- Co-authored-by: unknown <[email protected]> Co-authored-by: Anik Dhabal Babu <81948346 [email protected]> * fix: #15697 Assignment warning modal poping up ,even when hosts are added . (#15699) * removed reduntand check on assignedusers * update for managed eventtype * formatted * comments * Updated comments * extracted checkForEmptyAssignment and added tests * updated comments * updated to show dialog also when not yet saved * update translations * updated comments * updated translation * updated types * chore: update naming and comments * Delete apps/web/lib/checkForEmptyAssignment.ts deleted since file was renamed * Delete apps/web/test/lib/checkForEmptyAssignment.test.ts deleted as the file is renamed to be more descriptive * update to do teamcheck before * chore: revert name to CheckForEmptyAssignment * updated check conditions * updated useEffect dependencies --------- Co-authored-by: Anik Dhabal Babu <81948346 [email protected]> * fix: getting an error when a team member tries to leave (#15925) a team Co-authored-by: Somay Chauhan <[email protected]> Co-authored-by: Amit Sharma <74371312 [email protected]> * feat: add transitions to more components (#15916) * add transitions to more components * chore: Remove duplicate class * fix: Change minimum number of teams required for org self-serve (#15955) * fix: Change minimum number of teams required for org self-serve Signed-off-by: Souptik Datta <[email protected]> * refactor: Use a new constant for displaying org helper text dialogue Signed-off-by: Souptik Datta <[email protected]> * Update packages/lib/constants.ts * Update turbo.json --------- Signed-off-by: Souptik Datta <[email protected]> Co-authored-by: Keith Williams <[email protected]> * feat: pwa ready and add shortcut for quick access (#15957) * chore: Update site.webmanifest with additional display properties * chore: Update site.webmanifest with additional display properties * Update apps/web/public/site.webmanifest --------- Co-authored-by: Keith Williams <[email protected]> * i18n: update translations for "by proceeding, ..." (#15921) * feat: Add title attribute to iframe in embed.ts (#18634) * feat: Add title attribute to iframe in embed.ts * Update packages/embeds/embed-core/src/embed.ts --------- Co-authored-by: Hariom Balhara <[email protected]> * fix: Assignment reminder modal appears when deleting a team event type (#15544) * fix: Assignment reminder modal appears when deleting a team event type * update * Update EventTypeSingleLayout.tsx * Update event-types-single-view.tsx * update * Early return https://handbook.cal.com/engineering/best-practices/prefer-early-returns --------- Co-authored-by: Keith Williams <[email protected]> Co-authored-by: Hariom <[email protected]> * fix: Add CORP and COEP headers to embedded pages (#15275) * Add CORP headers * Improve test * Add unit tests as well --------- Co-authored-by: Keith Williams <[email protected]> * feat: No-show bookings - do not count towards a member's round robin assignment (#15323) * feat: No-show bookings - do not count towards a member's round robin assignment * filter no show organizer * remove logs * fix: filter bookings where host attendee is no show * fix: use not condition for noShow * chore: test * add default false for noShowHost * Revert "chore: test" This reverts commit c914a8f. * chore: integration test * fix: noShowHost not working for null * Update packages/lib/server/getLuckyUser.ts * chore: update test description --------- Co-authored-by: Joe Au-Yeung <65426560 [email protected]> Co-authored-by: Udit Takkar <53316345 [email protected]> Co-authored-by: gh0st91848 <[email protected]> Co-authored-by: Hariom Balhara <[email protected]> * refactor: v1 orgs unlimited teams (#15908) * refactor: v1 orgs unlimited teams * fix: response message ownerId --------- Co-authored-by: Keith Williams <[email protected]> * fix: refresh connect atoms on token change (#15933) * added dropdown * change comment * fix: added types --------- Co-authored-by: Morgan <33722304 [email protected]> Co-authored-by: Keith Williams <[email protected]> * fix: Next.js bundle analysis (#15903) * fix: Next.js bundle analysis * Added the main checkout back * fix: type in webhook payload (#15912) Co-authored-by: CarinaWolli <[email protected]> * fix: auto accept (#15975) * fix: auto accept * Update packages/lib/server/repository/organization.ts Co-authored-by: Hariom Balhara <[email protected]> --------- Co-authored-by: Hariom Balhara <[email protected]> * fix: Broken GitHub workflows (#15979) * test: Delete credential endpoint (#15322) * Init * Add mock trpc context * Intro mockDatabaseClient * Introduce mockDatabaseClient class * Add delete video app test * Add calendar test * Remove unused func from bookingScenario * Remove console.log * Add app repository * Add createMany method to event type repository * Remove instance of MockDatabaseClient from video test * Add destination calendar repository * Remove instances of MockDatabaseClient * abstract logic to own handler * Remove dev dependency * Clean up * Type fix * Pull yarn.lock from main --------- Co-authored-by: Anik Dhabal Babu <81948346 [email protected]> * fix: #15967 Show better error when wrong variable is used in custom event name (#15974) * update to show exact err msg with custom event name * updated tests for validateCustomEventName --------- Co-authored-by: Keith Williams <[email protected]> Co-authored-by: Anik Dhabal Babu <81948346 [email protected]> * WIP Signed-off-by: zomars <[email protected]> * Update yarn.lock * Update publish.handler.ts * Update internal-team-billing.test.ts * rename create to init * remove sync services * wip tests for delete team * wip tets * wip tests * tests/internal-test * remove return that is inaccessable * remove team calls to use repository * remove redudant file * update team repo * add stripe mocks and test * fix constants * tests to main stripe handler * remove logs * fix constants * Update packages/features/ee/billing/api/webhook/_customer.subscription.deleted.team-plan.ts Co-authored-by: Omar López <[email protected]> * move workflow logic to a service * use static method > creating new class * fix: remove http code deep in repo tests * Feedback * Update index.ts * Type fix * Lazy load fixes --------- Signed-off-by: zomars <[email protected]> Signed-off-by: Souptik Datta <[email protected]> Co-authored-by: Rohan Advani <122167726 [email protected]> Co-authored-by: unknown <[email protected]> Co-authored-by: Anik Dhabal Babu <81948346 [email protected]> Co-authored-by: Vijay <[email protected]> Co-authored-by: Somay Chauhan <[email protected]> Co-authored-by: Amit Sharma <74371312 [email protected]> Co-authored-by: Hichem Fantar <[email protected]> Co-authored-by: Souptik Datta <[email protected]> Co-authored-by: Keith Williams <[email protected]> Co-authored-by: Johannes Maendle <141119154 [email protected]> Co-authored-by: Hariom Balhara <[email protected]> Co-authored-by: Joe Au-Yeung <65426560 [email protected]> Co-authored-by: Udit Takkar <53316345 [email protected]> Co-authored-by: gh0st91848 <[email protected]> Co-authored-by: Lauris Skraucis <[email protected]> Co-authored-by: Morgan <33722304 [email protected]> Co-authored-by: Carina Wollendorfer <30310907 [email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: sean-brydon <55134778 [email protected]> Co-authored-by: sean-brydon <[email protected]> Co-authored-by: sean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐛 bug
Something isn't working
consumer
core
area: core, team members only
ready-for-e2e
webhooks
area: webhooks, callback, webhook payload
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
type
in the webhook payload should be the event type slug not title.