-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.0: Rename EntityTrait::_accessible
property to something more appropriate
#17375
Labels
Milestone
Comments
|
Given that most folks interact with mass-assignment via the ORM methods, what about |
This issue is stale because it has been open for 120 days with no activity. Remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I never really liked the name of the
_accessible
property inside ourCake\Datasource\EntityTrait
since just by its name it indicates some sort of permission system to prevent (general) access to specified properties inside PHP... which it doesn't do.The concept of
mass assignment
is properly described in the Docs and the baked entity classes also have a somewhat suitable explenation of what is happening but still the property name itself is a bit missleading imho.Here are some of my (bad) suggestions that came to my mind:
massAssignable
(to be right on the nose but still what doesassignable
mean)massEditable
(although this also doesn't represent it correctly because$entity->set('myfield', 'value');
would also be blocked ifmyfield
is set tofalse
)Would love to hear your thoughts on that one 😁
CakePHP Version
6.0
The text was updated successfully, but these errors were encountered: