Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow input presentation #620

Conversation

Assem-Hafez
Copy link
Contributor

Problem

Workflow input have a confusing presentation. It is hard to differentiate between having multiple input parameters or a single array parameter.

For example:

  • If the workflow input was 3 parameters 1,2,3 the input would be represented as [1,2,3]
  • while if the workflow input was a single parameter with an array value [1,2,3] the input would also be represented as [1,2,3]

This happens because the logic ignores adding array brackets if there is a single parameter, which causes confusion when the input is a single parameter of type array, as it is not clear if this is a single array or multiple params.

The fix is to add array brackets around parameters in cases.

Also the logic was revisited as it used to depend on , to separate input parameters which can break if the parameters themselves included commas.

Screenshots

Single parameter before the changes
image

Single parameter after the changes
image

Multiparameter before & after changes
image

@Assem-Uber Assem-Uber merged commit b7593c8 into cadence-workflow:master Jul 29, 2024
4 checks passed
@Assem-Hafez Assem-Hafez mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants