Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain search page crash for crossRegion environments #532

Conversation

Assem-Uber
Copy link
Contributor

Description:
While working on the feature for redirection to the default cluster, the code started depending on clusters list getter. This getter was crashing on the domain search page because domain at that point is empty.

The fix:
Return empty clusters list array if domain is missing.

Other changes:

  • Unit test was added to make sure the clusters list getter would always return empty array its dependent getter returns null.
  • after reading more through the code i tweaked the code for redirection to only set the cluster name in the route if the route actually has clusterName param in its definition. (this is not related to the error but can prevent some if the new routes are added that doesn't have clusterName param)

@Assem-Uber Assem-Uber merged commit dae0d08 into cadence-workflow:master Dec 1, 2023
2 checks passed
@Assem-Uber Assem-Uber deleted the CDNC-6320-fix-crash-on-domain-search-page-in-cross-region-envs branch December 1, 2023 10:26
@adhityamamallan adhityamamallan mentioned this pull request Dec 5, 2023
@adhityamamallan adhityamamallan mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants