recycle xmitBuf uniformly

c33dd · Nov 4, 2019 · 9f0f2bc · 9f0f2bc
1 parent 6e70521
commit 9f0f2bc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/sess.go b/sess.go
@@ -333,6 +333,10 @@ func (s *UDPSession) WriteBuffers(v [][]byte) (n int, err error) {
 func (s *UDPSession) uncork() {
 	if len(s.txqueue) > 0 {
 		s.tx(s.txqueue)
+		// recycle
+		for k := range s.txqueue {
+			xmitBuf.Put(s.txqueue[k].Buffers[0])
+		}
 		s.txqueue = nil
 	}
 	return

diff --git a/tx.go b/tx.go
@@ -14,7 +14,6 @@ func (s *UDPSession) defaultTx(txqueue []ipv4.Message) {
 		if n, err := s.conn.WriteTo(txqueue[k].Buffers[0], txqueue[k].Addr); err == nil {
 			nbytes += n
 			npkts++
-			xmitBuf.Put(txqueue[k].Buffers[0])
 		} else {
 			s.notifyWriteError(errors.WithStack(err))
 			break

diff --git a/tx_linux.go b/tx_linux.go
@@ -25,7 +25,6 @@ func (s *UDPSession) tx(txqueue []ipv4.Message) {
 		if n, err := s.xconn.WriteBatch(txqueue, 0); err == nil {
 			for k := range txqueue[:n] {
 				nbytes += len(txqueue[k].Buffers[0])
-				xmitBuf.Put(txqueue[k].Buffers[0])
 			}
 			npkts += n
 			txqueue = txqueue[n:]