Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cranelift: Register all functions in test file for interpreter #4800

Merged
merged 2 commits into from
Aug 29, 2022
Merged

cranelift: Register all functions in test file for interpreter #4800

merged 2 commits into from
Aug 29, 2022

Conversation

afonso360
Copy link
Contributor

👋 Hey,

This does a similar refactor to #4667 but for the interpreter. Mostly to ensure that we can keep adding test interpret to any run tests that may come up.

call_indirect tests are not enabled because we don't support them yet.

It also implements bnot for booleans since one of the call tests uses it.

@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Aug 27, 2022
jameysharp
jameysharp approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jameysharp jameysharp enabled auto-merge (squash) August 29, 2022 23:11
@jameysharp jameysharp merged commit 500a9f1 into bytecodealliance:main Aug 29, 2022
@cfallin
Copy link
Member

cfallin commented Aug 30, 2022

This seems to be causing a regression on main, probably due to a stale test run:

thread 'worker #7' panicked at 'Unexpected returned control flow: Trap(User(BadSignature))', cranelift/filetests/src/test_interpret.rs:112:29
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
FAIL filetests/filetests/runtests/call.clif: panicked in worker #7: Unexpected returned control flow: Trap(User(BadSignature))
506 tests
Error: 1 failure

(found by @elliottt)

I'll create a revert PR for this momentarily!

cfallin added a commit to cfallin/wasmtime that referenced this pull request Aug 30, 2022
@cfallin
Revert "cranelift: Register all functions in test file for interpreter (
48155cf 
bytecodealliance#4800)"

This reverts commit 500a9f1.
@cfallin cfallin mentioned this pull request Aug 30, 2022
Merged
cfallin added a commit that referenced this pull request Aug 30, 2022
@cfallin
Revert "cranelift: Register all functions in test file for interpreter (
2b4b257 
#4800)" (#4810)

This reverts commit 500a9f1.
@afonso360 afonso360 mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameysharp jameysharp jameysharp approved these changes

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afonso360 @cfallin @jameysharp