Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include plugins in nav as external #1410

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Conversation

TChukwuleta
Copy link
Contributor

@ndeet included plugins documentations for some other plugins as external links in the plugin navs

@dennisreimann
Copy link
Member

Why not integrate them directly, like we did with the other ones?

@TChukwuleta
Copy link
Contributor Author

yea.. I think that'd be cooler.

I'd update it

@ndeet
Copy link
Contributor

ndeet commented Jun 24, 2024

Yes that would also work, then add it to Plugins section in the sidebar like this

@TChukwuleta
Copy link
Contributor Author

made the update @dennisreimann @ndeet

You can take another look

@dennisreimann
Copy link
Member

dennisreimann commented Jun 25, 2024

Very good! Only thing I saw: There seems to be something funky going on with the first headline of the SideShift and Dynamic Reports plugins. Their source looks fine though.

@ndeet
Copy link
Contributor

ndeet commented Jun 25, 2024

Yes, those two headlines seem to have some formatting issue, maybe some whitespace in front or at the end of the headlines?

I would also add rockstardev's Payroll plugin and Nicolas Boltcard plugin

@TChukwuleta
Copy link
Contributor Author

Sideshift and Dynamic reports are fine now. I removed unprintable characters from readme

I'd add the payroll and the boltcard plugin

@TChukwuleta
Copy link
Contributor Author

TChukwuleta commented Jul 24, 2024

Hey @ndeet I think we can merge this for now. There is an issue with Boltcard ReadMe file. Tried reformatting and all but not still working but other ReadMe file works

I would probably open a PR on the bolt card plugin. But I believe we are good to go on the others including payroll plugin

@pavlenex
Copy link
Contributor

LGTM. Great improvements @TChukwuleta 🎉 Some of these require cleanups (the readme's) but that's unrelated to this PR.

@pavlenex pavlenex merged commit 6c95ee5 into btcpayserver:master Jul 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants