Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for acquiring OpenID claims when making a token request with a UserCredentials grant #973

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcherniak
Copy link

No description provided.

Copy link
Owner

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merry Christmas! This is a great pull request, thank you for your contribution! A few thoughts:

  1. The tests are failing because issuer needs to be set on the server in order to use the IdToken storage in OpenId\GrantType\AuthorizationCodeTest.

  2. This brings up the issue of backwards compatibility.Your changes will break those who are currently using use_openid_connect but have not set the issuer parameter. While it's unlikely someone would be doing this, it's unfortunately possible.
    Another issue is someone could update this dependency and now their token controller behaves differently than before (e.g. responding to the openid scope) without their knowledge. So it may be best to submit this to the 2.x branch and I can push to getting a new version out. We can also submit it to the master branch, but use a different config parameter, e.g. use_openid_connect_token_controller

  3. Please add tests for the new functionality!

Thanks again, I'm excited to get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants