add PDO storage support for refresh tokens #9
Conversation
- Included OAuth2_Storage_RefreshTokenInterface and functions for PDO support of refresh_tokens - Renamed table vars in config array
|
|
||
| public function unsetRefreshToken($refresh_token) | ||
| { | ||
| unset($this->refreshTokens[$refresh_token]); |
There was a problem hiding this comment.
This is not valid for the PDO storage engine. This should issue a delete statement
There was a problem hiding this comment.
Thank you for catching that. Submitted commit to fix.
unsetRefreshToken was not properly defined and therefore would not delete a refresh_token when consumed.
|
Okay a couple more things...
Also... why did you decide to change the config value names? I'm guessing for brevity? |
|
For #1-- gotcha and will do. For #2-- will remove. As to the config value changes-- they stemmed from the new value needed to store the refresh token table. Initially, I used "refresh_token_table_name" and renamed "token_table_name" to "access_token_table_name", but felt those were a getting a bit longer than necessary and figured "_name" could be dropped without loosing meaning. |
|
Closing this request. Will resubmit to merge with development branch. |
support of refresh_tokens
Resubmitting with only the refresh token addition. Figured out the Travis-Cl stuff (neat!) and it passed.