Updated getAccessTokenData() to accept a $request #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce) so that it is easier to use it.
|
Looks great! Thankyou sir! A little constructive feedback - typically it's best to make topic branches for each PR. That way if you're working on more than one PR, or if you need to make changes, you don't wonk with your master branch :) |
bshaffer
added a commit
that referenced
this pull request
Jan 25, 2013
Updated getAccessTokenData() to accept a $request
|
@bshaffer Good point :) I will sort that out on my fork :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to close #31 :)