Fixed JWT Bearer Test for PHP 5.3.3 and below #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting this: https://travis-ci.org/bshaffer/oauth2-server-php/jobs/4342679 |
|
Yup, that's because PHP 5.2 does not support openssl on travis-ci. I thought that should be fixed with the pull that checked the version (in the last merge) and used a symmetric algorithm for generating the JWT on PHP 5.2, but the build failed. I am just waiting for this pull to build to see if it passes, because I don't have PHP 5.2 on my VMs. Build for this pull: https://travis-ci.org/bshaffer/oauth2-server-php/builds/4343292 |
|
Yay, the build passes :) Must have been an issue with detecting the PHP version. |
bshaffer
added a commit
that referenced
this pull request
Jan 24, 2013
Fixed JWT Bearer Test for PHP 5.3.3 and below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 5.3.3 and below does not support openssl on travis-ci.
This pull request should fix it by using the SHA-256 algorithm for generating JWTs for PHP 5.3.3 and below.