Documentation for JWT Grant Type and checking of "sub" JWT parameter #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arer grant type to require and check for the "sub" property in the JWT.
Closed
| * @param The expiration date. If the current time is greater than the exp, the JWT is invalid. $exp | ||
| * @param The "not before" time. If the current time is less than the nbf, the JWT is invalid. $nbf | ||
| * @param The issuer, usually the client_id. $iss | ||
| * @param $exp The expiration date. If the current time is greater than the exp, the JWT is invalid. |
There was a problem hiding this comment.
Looks awesome!! but Nulls should be lowercase
There was a problem hiding this comment.
Can't believe I missed that. That is now fixed. I also found another instance of NULL in one of the interfaces. That has now been fixed as well. :)
| * @return string | ||
| */ | ||
| private function getJWT($exp = NULL, $nbf = NULL, $iss = 'Test Client ID') | ||
| private function getJWT($exp = NULL, $nbf = NULL, $sub = NULL, $iss = 'Test Client ID') | ||
| { |
There was a problem hiding this comment.
Looks like you ADDED an uppercase null! :)
There was a problem hiding this comment.
I must have gotten carried away and forgot to include that file in the commit. 📦
I have also lodge an issue with php-cs-fixer so that they can include lowercasing of PHP keywords into the fixer :)
bshaffer
added a commit
that referenced
this pull request
Jan 19, 2013
Documentation for JWT Grant Type and checking of "sub" JWT parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the documentation for the JWT Grant Type.
I also found that the latest spec required validation of the "sub" JWT parameter, so that is also now validated. Tests has been updated to reflect this.