-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For boolean flags, confused on when to use "--no-*" pattern and when to "--flag True/False" pattern #140
Comments
chengluberkeley
changed the title
For boolean flags, confused on when to use "--no-*" pattern, or when to "flag True/False" pattern
For boolean flags, confused on when to use "--no-*" pattern and when to "flag True/False" pattern
Apr 24, 2024
chengluberkeley
changed the title
For boolean flags, confused on when to use "--no-*" pattern and when to "flag True/False" pattern
For boolean flags, confused on when to use "--no-*" pattern and when to "--flag True/False" pattern
Apr 24, 2024
Hello! The reason for this is that Nerfstudio types are often wrapped with See here for an example: https://brentyi.github.io/tyro/examples/04_additional/07_conf/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, I am reading the tyro documentation on the boolean flags: https://brentyi.github.io/tyro/examples/01_basics/05_flags/ and get confused. Because when I refer to Nerfstudio here: https://github.com/nerfstudio-project/nerfstudio/blob/main/nerfstudio/configs/base_config.py#L143, according to the documentation, since it has default value, it should have flags:
--viewer.quit-on-train-completion
and--viewer.no-quit-on-train-completion
. But this one is translated in tyro to--viewer.quit-on-train-completion True/False
. Do I miss something? Thanks.The text was updated successfully, but these errors were encountered: