Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<b>, <br> and <i> tags #4

Closed
slavaGanzin opened this issue Apr 25, 2017 · 3 comments
Closed

<b>, <br> and <i> tags #4

slavaGanzin opened this issue Apr 25, 2017 · 3 comments

Comments

@slavaGanzin
Copy link

slavaGanzin commented Apr 25, 2017 •
edited
Loading

Hello, thanks for awesome project

console.log(breakdance('<b>fail</b><br><i>fail</i><br><strong>success</strong>'))
<b>fail</b><br>
<i>fail</i><br>
**success**

As I found playing with markup while writing this issue. <b> <i> and <br> works as is and can be not transpiled into markdown **bold** *italic* \n. It would be great if this would be documented in breakdance.

Indeed I need this behavior. Of course I can write my own regexps or tune handlers and I'll do so. But I think there should be a option key that change this behaviour

Thanks for you work
@jonschlinkert
Copy link
Member

jonschlinkert commented Apr 25, 2017 •
edited
Loading

Agreed, I'll push up a fix. thanks for the issue

edit, I only agree on the <b> and <i> tags... I think <br> should stay how it is since it's more likely to be necessary for retaining significant whitespace. However, we could easily expose an option/flag for that.

@jonschlinkert
Copy link
Member

published and released as 2.0.0. I had to do a major since this is a breaking change.

@slavaGanzin
Copy link
Author

Thanks for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonschlinkert @slavaGanzin