Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] "Send" button on NFT details screen is not shown for owned EVM NFTs #39882

Closed
2 of 6 tasks
josheleonard opened this issue Jul 19, 2024 · 2 comments · Fixed by brave/brave-core#24777
Closed
2 of 6 tasks

[Wallet] "Send" button on NFT details screen is not shown for owned EVM NFTs #39882

josheleonard opened this issue Jul 19, 2024 · 2 comments · Fixed by brave/brave-core#24777
Assignees
@josheleonard
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum wallet support front-end-change This task is a front end task and doesn't need any C changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@josheleonard
Copy link

Description

The "Send" button is not shown in the NFT details screen for EVM NFTs owned by a wallet account

Steps to reproduce

  1. import/restore a wallet which owns EVM NFTs
  2. go to the NFTs tab of the portfolio
  3. click on an EVM NFT which is owned by an account
  4. observe the header of the details screen

Actual result

The "Send" button is missing

Expected result

The "Send" button is should be shown

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.69.117 Chromium: 127.0.6533.57 (Official Build) beta (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@josheleonard josheleonard added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C changes feature/web3/wallet/nft labels Jul 19, 2024
@josheleonard josheleonard self-assigned this Jul 19, 2024
@josheleonard josheleonard mentioned this issue Jul 22, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Jul 22, 2024
@brave-builds brave-builds mentioned this issue Jul 22, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.69.123 or higher for 1.69.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Aug 2, 2024

Verification passed on

Brave 1.69.131 Chromium: 127.0.6533.88 (Official Build) beta (64-bit)
Revision 7f9c5cb9840ea18f57d485ee263b5bf4b1075953
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from issue description
  • Verified Send button is shown for owned ERC721 tokens
  • Verified Send button is not shown for unowned ERC721 tokens
39882.mp4

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum wallet support front-end-change This task is a front end task and doesn't need any C changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

Fix(wallet): show send button on NFT details screen when ERC721 NFT is owned brave/brave-core
4 participants
@kjozwiak @srirambv @josheleonard @brave-builds