Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unchecked NFTs should be shown under Hidden NFT #31134

Closed
srirambv opened this issue Jun 19, 2023 · 1 comment
Closed

Unchecked NFTs should be shown under Hidden NFT #31134

srirambv opened this issue Jun 19, 2023 · 1 comment
Assignees
@muliswilliam
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@srirambv
Copy link
Contributor

Description

Unchecked NFTs should be shown under Hidden NFT

Steps to Reproduce

  1. Add an NFT to collection
  2. Go to portfolio and search for NFT
  3. Unchecked the visible checkbox
  4. Go to NFT tab and select Hidden
  5. NFT removed from step 3 isn't shown under hidden

Actual result:

Unchecked NFTs should be shown under Hidden NFT

Expected result:

Should move visible NFT to hidden tab if the NFT is unchecked from visible asset list

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @kleantzogu @muliswilliam
@srirambv srirambv added bug QA/Yes feature/web3/wallet Integrating Ethereum wallet support OS/Desktop labels Jun 19, 2023
@srirambv srirambv mentioned this issue Jun 19, 2023
Closed
@HEagle18 HEagle18 added feature/web3/wallet/nft priority/P4 Planned work. We expect to get to it "soon". labels Jun 23, 2023
@muliswilliam muliswilliam self-assigned this Sep 7, 2023
@josheleonard
Copy link

Closing since this is no longer valid. NFTs are not listed in the edit visible assets modal anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
Web3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@HEagle18 @srirambv @josheleonard @muliswilliam