Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve controller error to be module-wide #223

Merged
merged 1 commit into from
Jul 21, 2022
Merged

improve controller error to be module-wide #223

merged 1 commit into from
Jul 21, 2022

Conversation

gthao313
Copy link
Member

@gthao313 gthao313 commented Jul 13, 2022 •
edited
Loading

Issue number:
part of #121

Description of changes:

Author: Tianhao Geng <[email protected]>
Date:   Wed Jul 13 21:50:20 2022  0000

    controller - create multiple error classifications

    Error submodules are preferred for error types, and it is preferable to
    create multiple error classifications rather than bubbling all errors up
    to a single error type. In this change, we create multiple error
    classifications for controller.

Testing done:
integration test

kubectl -n brupop-bottlerocket-aws get pods
NAME                                           READY   STATUS    RESTARTS   AGE
brupop-agent-cdv8x                             1/1     Running   2          42m
brupop-agent-f7klw                             1/1     Running   2          42m
brupop-agent-srjkk                             1/1     Running   1          42m
brupop-apiserver-764ddfb979-9tdhd              1/1     Running   0          30m
brupop-apiserver-764ddfb979-bspxl              1/1     Running   0          30m
brupop-apiserver-764ddfb979-zgqdp              1/1     Running   0          35m
brupop-controller-deployment-9d7d76b97-xrx67   1/1     Running   0          35m

NAME                                                STATE   VERSION   TARGET STATE   TARGET VERSION   CRASH COUNT
brs-ip-192-168-135-133.us-west-2.compute.internal   Idle    1.8.0     Idle                            0
brs-ip-192-168-146-35.us-west-2.compute.internal    Idle    1.8.0     Idle                            0
brs-ip-192-168-151-76.us-west-2.compute.internal    Idle    1.8.0     Idle                            0

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@gthao313 gthao313 marked this pull request as ready for review July 13, 2022 22:44
@gthao313
controller - create multiple error classifications
1cd859e 
Error submodules are preferred for error types, and it is preferable to
create multiple error classifications rather than bubbling all errors up
to a single error type. In this change, we create multiple error
classifications for controller.
@gthao313
Copy link
Member Author

push above solving conflicts

@gthao313 gthao313 merged commit cc27cc2 into bottlerocket-os:develop Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somnusfish somnusfish somnusfish approved these changes

@cbgbt cbgbt cbgbt approved these changes

@arnaldo2792 arnaldo2792 Awaiting requested review from arnaldo2792

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gthao313 @cbgbt @somnusfish @arnaldo2792