Use settings models vended by bottlerocket-settings-sdk #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force pushed to fix failing unit tests. |
|
^ Clippy fixes |
|
^ Moves to official upstream package, now that bottlerocket-os/bottlerocket-settings-sdk#41 is merged. |
webern
approved these changes
Jun 17, 2024
webern
approved these changes
Jun 20, 2024
bcressey
approved these changes
Jun 20, 2024
sam-berning
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This modifies the Bottlerocket sources to use models sourced by the Bottlerocket settings SDK.
This change is currently based on a WIP draft PR in the SDK repo, bottlerocket-os/bottlerocket-settings-sdk#41
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.