Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic require with safe_require prints a warning in Webpack 5 #117

Open
amannn opened this issue Aug 3, 2023 · 0 comments
Open

Dynamic require with safe_require prints a warning in Webpack 5 #117

amannn opened this issue Aug 3, 2023 · 0 comments

Comments

@amannn
Copy link

amannn commented Aug 3, 2023

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/casual/src/casual.js b/node_modules/casual/src/casual.js
index 9179af1..0706dca 100644
--- a/node_modules/casual/src/casual.js
    b/node_modules/casual/src/casual.js
@@ -1,12  1,6 @@
 var helpers = require('./helpers');
 var exists = require('fs').existsSync;
-
-var safe_require = function(filename) {
-	if (exists(filename   '.js')) {
-		return require(filename);
-	}
-	return {};
-};
 var path = require('path');
 
 var build_casual = function() {
 	var casual = helpers.extend({}, helpers);
@@ -40,9  34,16 @@ var build_casual = function() {
 			var casual = build_casual();
 
 			providers.forEach(function(provider) {
 				let localeProvider = {};
 				try {
 					localeProvider = require(__dirname   '/providers/'   locale   '/'   provider)
 				} catch (e) {
 					// Nothing to do
 				}
 
 				casual.register_provider(helpers.extend(
 					require('./providers/'   provider),
-					safe_require(__dirname   '/providers/'   locale   '/'   provider)
 					localeProvider
 				));
 			});
 

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant