-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitcoin getnetworkhashps overflow #933
Comments
which version of bitcoin, 0.16 or 0.15 series? |
bitcoind version is at the latest stable 0.15.1. Do I need a newer one? |
Nah, 0.16 will be going changes and i thought this would be about it - but seems not. |
im having same error. works with other coins though |
Thanks bonesoul guess it's waiting on next Bitcoin update |
actually we can fix it i guess. |
Everything's possible :-) I'm enjoying using coiniumserv so far best stratum mpos jobby I have found. Supports enough coins for my liking. And minimal issues bar resources running out. There is an odd one that makes me have to put a fee on and basically mints 1 less coin than reward is for the block and it's not dev fees because set to 0 fee it won't mine and set to 0.1 It takes 1.1 off. Only did that with one coin though. Incakoin if you want to test it. Have to set up extras in conf :-/ |
Dears, Do you have any idea to sovled this? I've downgraded a bitcoin core from 15.1 to 15.0 but problem is not solved. so just wonder if this able to fix later on Regards, |
They will Probably change getnetworkhashps to getnetworkmhashps in the Bitcoin client or get it futureproof and use getnetworkphashps I missed the first line myself. It's exponential numbers. E 19 makes for a very very large number. If mhsps that's down to a smaller number but Mayne still an exponent so then it would need to be ghsps |
Dears,
So should I change a source code in order to solved this issue?
if you have any idea share please...
Regards,
John Ahn
-----Original Message-----
From: "regtable"<[email protected]>
To: "bonesoul/CoiniumServ"<[email protected]>;
Cc: "jeong760"<[email protected]>; "Comment"<[email protected]>;
Sent: 2018-01-30 (화) 13:41:03
Subject: Re: [bonesoul/CoiniumServ] Bitcoin getnetworkhashps overflow (#933)
They will Probably change getnetworkhashps to getnetworkmhashps in the Bitcoin client or get it futureproof and use getnetworkphashps I missed the first line myself. It's exponential numbers. E 19 makes for a very very large number. If mhsps that's down to a smaller number but Mayne still an exponent so then it would need to be ghsps
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
No I think it will be done in the Bitcoin client code. So it handles the request differently and outputs a more humane number. If not then yes I'm sure something could be done in code but that will break a lot of other things I'm sure. Lets see what bonesoul thinks. But I will see what can be done in the mean time. This must be a recent issue with the skyrocket in hashpower |
@regtable, I am not sure this is solved by following but mine has been gone above issue.
{
|
I will try that.
…On 1 Feb 2018 14:11, "jeong760" ***@***.***> wrote:
@regtable <https://github.com/regtable>, I am not sure this is solved by
following but mine has been gone above issue.
- Create a each coins config file separtly like following
The sample of bitcoin.json
{
"enabled":true,
"coin": "bitcoin.json",
"daemon": {
"host": "127.0.0.1",
"port": 8332,
"username": "RPC username",
"password": "Password of RPC user"
},
"meta": {
"motd": "Welcome to CoiniumServ pool, enjoy your stay! -
http://www.coiniumserv.com",
"txMessage": "http://www.coiniumserv.com/"
},
"wallet" : {
"address": "1MMdwRZg4K9p6oH2bWUQdohbxGbAvXS1t1"
},
"rewards": [
{"1MMdwRZg4K9p6oH2bWUQdohbxGbAvXS1t1": 1}
],
"banning": {
"enabled": true,
"duration": 600,
"invalidPercent": 50,
"checkThreshold": 100,
"purgeInterval": 300
},
"payments": {
"enabled": true,
"interval": 60,
"minimum": 0.01
},
"miner": {
"validateUsername": true,
"timeout": 300
},
"job": {
"blockRefreshInterval": 1000,
"rebroadcastTimeout": 55
},
"stratum": {
"enabled": true,
"bind": "0.0.0.0",
"port": 3333,
"diff": 16,
"vardiff": {
"enabled": true,
"minDiff": 8,
"maxDiff": 512,
"targetTime": 15,
"retargetTime": 90,
"variancePercent": 30
}
},
"storage": {
"hybrid": {
"enabled": false,
"redis": {
"host": "127.0.0.1",
"port": 6379,
"password": "",
"databaseId": 0
},
"mysql": {
"host": "127.0.0.1",
"port": 3306,
"user": "username",
"password": "password",
"database": "db-name"
}
},
"mpos": {
"enabled": false,
"mysql": {
"host": "127.0.0.1",
"port": 3306,
"user": "username",
"password": "password",
"database": "db-name"
}
}
},
"vanilla": {
"enabled": false,
"bind": "localhost",
"port": 2223
}
}
- Change default.json as following and save.
default.json
{
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#933 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHQVF04oc_subaSQ_HyPIsmNATAKvvaSks5tQcYigaJpZM4Ru_Wm>
.
|
it did not help me :-/ |
Getting this error as well and for the life of me I can't get it to work. using 15.1 core. 02/04/2018 13:27:16 -08:00 [Information] [PlatformManager] [global] Running over .Net, framework: 4.5 (v4.0.30319.42000). |
You know when I removed a bitcoin client and installation again it works few times but after that it generate a above error. also bitcoin 15.1 does not support a getinfo() anymore it depreciated RPC command but still works with warning message. I think this problem of "Serilog", Newtonsoft.Json,Nancy does not have enough buffer for bitcoin difficult conversion. so this should be changed a some code. The warning message when issued a getinfo() |
I tried rolling the core back to 15.0 but still got errors |
of course it works perfectly for litecoin. altho I have yet to test the pool as I don't have a scrypt miner lol |
I think the issue occurs on line 75 in src/CoiniumServ/Daemon/Responses/MiningInfo.cs, the value being returned by the network is bigger than a UInt64 allows. I'm not really a C# developer so am not sure how to fix it. I've tried using double but this causes other issues, also tried BigInteger but it fails to compile on linux and I am unsure of how to include System.Numerics in the build. |
I have worked with c# will take a look at it, and yeah replacing just that with double don't fix it. |
@mbruton I've changed following all value ulong but not solved the problem. because using System; is a UInt64. but I don't know where I can change to solve this... src/CoininumServ/Daemon/Responses/miningInfo.cs
src/CoininumServ/Pools/INetworkInfo.cs src/CoininumServ/Pools/NetowkrInfo.cs
|
Wouldn't it just work by removing the 100010001000 maths and having it change a value from khs to mhs ghs or phs ? |
@jeong760 I believe ulong is also 64 bit and so not big enough. @regtable the value is being returned by the Bitcoin API and so is too big to fit into the variable and so it fails before the calculations are even performed, the value should be stored in NetworkHashps which comes from the API call getMiningInfo. |
@mbruton, Yes, ulong does not help to solve. |
@mbruton, Do you know the biggest value to replace a UInt64 in C#? I am not a programmer so don't know which value should I use. @bonesoul, Could you give us a clue to solve this? Because it seems able to solve but first I need to understand the structure... also your new hypepool project still does not support a sha256 and testing phase so... until then we need to use a CoiniumServ. |
I tried, but then it started throwing up cast errors on the build.
sometime this week I should be able to dig into it.
…On Wed, Feb 14, 2018 at 3:58 PM, jeong760 ***@***.***> wrote:
@mbruton <https://github.com/mbruton>, Do you know the biggest value to
replace a UInt64 in C#? I am not a programmer so don't know which value
should I use.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#933 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG4-p0UFVpLEW025Xv6fL-IcfaYSgLEMks5tU3M3gaJpZM4Ru_Wm>
.
|
Dears, VC2017 debugging phase point to the following /src/pool/DaemonBase.cs (175 ~ 189 lines) private DaemonResponse GetRpcResponse(HttpWebRequest httpWebRequest)
Regards, |
yes bitcoin has changed it's rpc response signature, i'll take a look. |
@bonesoul, Thank you. so that's why it still generate an error even if I changed a following on src/Daemon/Response/DaemonResponse.cs. Before After Regards, |
@bonesoul, here is getmininginfo code of bitcoin(16.01). which under sr/rpc/mining.cpp. UniValue getmininginfo(const JSONRPCRequest& request) Regards, |
Cool.
…On 14 Feb 2018 18:56, "Matt Bruton" ***@***.***> wrote:
@jeong760 <https://github.com/jeong760> I believe ulong is also 64 bit
and so not big enough.
@regtable <https://github.com/regtable> the value is being returned by
the Bitcoin API and so is too big to fit into the variable and so it fails
before the calculations are even performed, the value should be stored in
*NetworkHashps* which comes from the API call *getMiningInfo*.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#933 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHQVF1ZpYU0DKsAZ1UQBE899j_Biq3Qbks5tUyxWgaJpZM4Ru_Wm>
.
|
Dears, I've inquired about above issue on bitcoin git hub they told this answer. it means that we will need to change an integer to double or a more lager one in order to represent this values -- Replied on bitcoin git -- This has nothing to do with a change in Bitcoin Core, but with the fact that the network's hash rate is now too large for your software to deal with. Regards, |
Do we need to change a pool.cs on following but after I change it generate an error. so how I fixed it? When after I changed an integer as ulong to double on both (Networkinfo.cs and INetworkInfo.cs) Error CS1929 'double' does not contain a definition for 'GetReadableHashrate' and the best extension method overload 'Humanize.GetReadableHashrate(ulong)' requires a receiver of type 'ulong' CoiniumServ D:\git\CoiniumServ\src\CoiniumServ\Pools\NetworkInfo.cs 153 Active src/pools/INetworkinfo.cs (code line 87-160) src/pools/networkinfo.cs (code line 46) src/pools/networkinfo.cs (code line 110 till to 126)
Regards, |
@bonesoul is there anything should I change? |
@bonesoul and Others, I think I've solved(Refers to pictures) a Network Hash rate issue on CoinuimServ after made several tests by my self. I've lost and don't know why but found that public static string GetReadableHashrate(this double hashrate) on Humanize.cs to give a Hashrate.GetReadableHashrate() on NetowrkInfo.cs. so I've additionally changed it, And then it works well with Bitcoin. src/Algorithms/HashAlgorithmStatistics.cs src/Algorithms/IHashAlgorithmStatistics.cs src/Daemon/Responses/MiningInfo.cs src/Pools/NetworkInfo.cs src/Pools/INetworkInfo.cs src/Pools/Pools.cs src/Pools/IPools.cs src/Statistics/StatisticsManager.cs src/Statistics/IStatisticsManager.cs src/Utils/Humanize.cs And finally please removed following code on web. it seems not implemented on CoiniumServ Bitcoin network hash rate on CoiniumServ console Pool hash rate correctly displayed on web. Regards, |
@bonesoul, I will open a new PR for this issue after making a week test in my pool. So if you think this no need to open a PR then please apply it to yourself as soon as possible, please. |
@bonesoul , Could you add a Globaltoken(GLT) and its icon? I think it omitted. so need to manual add please |
@felixonmars @regtable @dracolumina @mbruton , Does anyone confirmation that above change not affect alt-coins work? |
Does any one knows how to solve the time out issue below: |
@Maleksh, please increased a memory on your system. Redis is in memory key value storage so it needed at least 1GB for it. I’ve recommanded you increase a yout system memory morethan 2GB. |
@jeong760 , I have 32GB installed on the Workstation, with 1 TB M550 Crucial SSD, including 1 GB Cache memory. no luck, memory usage not more than 4 GB. |
I ran into this same issue today. Is there anything I can do to help expedite a solution? |
I was able to Increase the Dot Net Framwork Threads by following the below instruction: New Error Below: Anyone have any idea what to do |
@BenKnigge Which kind of issue do you mean? bitcoin network hash rate issue or other like related Redis |
@jeong760 I have tried your changes, but when I go to compile I get the error Severity Code Description Project File Line Suppression State |
@jeong760 The same issue as in the stack trace. I ended up downgrading the full node to version 15 and it resolved the issue. |
Currently bitcoind returns a big float for getnetworkhashps:
This prevents CoiniumServ from starting up:
The text was updated successfully, but these errors were encountered: