-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add merge command #143
Conversation
Your PR title needs to be a conventional commit so the changelog generates correctly, probably |
Please update the README.md that includes the command instructions. |
0dac56a
to
ed35bd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review part 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
3bf182b
to
0533b86
Compare
Signed-off-by: Patrick Kwiatkowski <[email protected]>
Signed-off-by: Patrick Kwiatkowski <[email protected]>
Signed-off-by: Patrick Kwiatkowski <[email protected]>
0533b86
to
5aff9a3
Compare
Description
Added merge capability.
This first iteration of the merge command depends on the current state of protobom's merging capabilities by leveraging Union method on NodeLists and augment method for the new root node. All other operations for other types follow the same principle of if a field already exists don't update else update. Merging priority is determined by the left most specified document id.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist