Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: one-time backend setup in rootCmd.PersistentPreRun #137

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

jhoward-lm
Copy link
Contributor

Description

This PR refactors the initialization of the ent backend to occur one time during rootCmd.PersistentPreRun and pass the backend to sub commands in a context.

Type of change

  • Refactor

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jhoward-lm jhoward-lm added the enhancement New feature or request label Aug 21, 2024
@jhoward-lm jhoward-lm self-assigned this Aug 21, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner August 21, 2024 18:26
@jhoward-lm jhoward-lm merged commit 0c8d51b into main Aug 21, 2024
9 checks passed
@jhoward-lm jhoward-lm deleted the backend-init branch August 21, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants